🇦🇺Australia @malks

malks → created an issue.

Hi @sarwan_verma, you beat me to it! I think your indentation is not quite right and is breaking the lint step in the tests. Can you fix?

malks → created an issue.

Just adding to the conversation that we're seeing it on our site as well. Also only on production but only for certain roles. Our admin roles don't have the issue and users created to match roles that are having the issue don't have the issue either. A full cache clear fixed it but we found the command below was a little less extreme if it helps.

drush php:eval "\\Drupal\\Core\\Cache\\Cache::invalidateTags(['config:block.block.claro_primary_local_tasks']);" 

Moshe, when you say " We worked around it by setting max-age=0 on the tabs block", how did you do that?

I was just testing this and noticed that when "Force TFA setup" is selected the text box for "Skip Validation" is hidden. Is this as designed?

Doing some testing on this and hit an edge case that might be problematic. If the user hasn't set up TFA and doesn't know their password (e.g. they've got to the site via reset link) then they can't continue to setup as it requires their password. Realise this is probably a base TFA issue, but might be more problematic if we're forcing users to the setup page.

malks → made their first commit to this issue’s fork.

Kristen Pol → credited malks → .

@matthew.hallsworth.dpc I think this is mostly fine. As mentioned though in previous comments I don't think this can actually be compatible with D8 any longer as it has a requirement on Symfony 3. Might need maintainers to step in and comment.

+++ b/src/Plugin/KeyType/JwtRsKeyType.php
@@ -84,7 +84,9 @@ class JwtRsKeyType extends KeyTypeBase implements KeyPluginFormInterface {
+    if (PHP_VERSION_ID < 80000) {

I think remove this check and mark it as deprecation with a comment is better as it is still supported in PHP8 but is a nop. @deprecated might mean it gets removed at some stage.

+++ b/composer.json
@@ -12,7 +12,7 @@
+    "drupal/core": "^8.7.12 || ^9.0 || ^10.0",

Because D8 relies on Symfony 3 I don't think we can support D8 any longer and probably should remove the `^8.7.12` requirement. For example `Symfony\Contracts\EventDispatcher\Event` does not exist in Symfony 3.