Contrib.social

Automated Drupal 10 compatibility fixes

Open on Drupal.org →
Created on 16 June 2022, over 2 years ago
Updated 2 February 2023, almost 2 years ago

Problem/Motivation

Hello project maintainers,

This is an automated issue to help make this module compatible with Drupal 10.

To read more about this effort by the Drupal Association, please read: The project update bot is being refreshed to support Drupal 10 readiness of contributed projects →

Patches will periodically be added to this issue that remove Drupal 10 deprecated API uses. To stop further patches from being posted, change the status to anything other than Active, Needs review, Needs work or Reviewed and tested by the community. Alternatively, you can remove the "ProjectUpdateBotD10" tag from the issue to stop the bot from posting updates.

The patches will be posted by the Project Update Bot → official user account. This account will not receive any issue credit contributions for itself or any company.

Proposed resolution

You have a few options for how to use this issue:

  1. Accept automated patches until this issue is closed

    If this issue is left open (status of Active, Needs review, Needs work or Reviewed and tested by the community) and the "ProjectUpdateBotD10" tag is left on this issue, new patches will be posted periodically if new deprecation fixes are needed.

    As the Drupal Rector project improves and is able to fix more deprecated API uses, the patches posted here will cover more of the deprecated API uses in the module.

    Patches and/or merge requests posted by others are ignored by the bot, and general human interactions in the issue do not stop the bot from posting updates, so feel free to use this issue to refine bot patches. The bot will still post new patches then if there is a change in the new generated patch compared to the patch that the bot posted last. Those changes are then up to humans to integrate.

  2. Leave open but stop new automated patches.

    If you want to use this issue as a starting point to remove deprecated API uses but then don't want new automated patches, remove the "ProjectUpdateBotD10" tag from the issue and use it like any other issue (the status does not matter then). If you want to receive automated patches again, add back the "ProjectUpdateBotD10" tag.

  3. Close it and don't use it

    If the maintainers of this project don't find this issue useful, they can close this issue (any status besides Active, Needs review, Needs work and Reviewed and tested by the community) and no more automated patches will be posted here.

    If the issue is reopened, then new automated patches will be posted.

    If you are using another issue(s) to work on Drupal 10 compatibility it would be very useful to other contributors to add those issues as "Related issues" when closing this issue.

Remaining tasks

Using the patches

  1. Apply the latest patch in the comments by Project Update Bot → or human contributors that made it better.
  2. Thoroughly test the patch. These patches are automatically generated so they haven't been tested manually or automatically.
  3. Provide feedback about how the testing went. If you can improve the patch, post an updated patch here.

Providing feedback

If there are problems with one of the patches posted by the Project Update Bot → , such as it does not correctly replace a deprecation, you can file an issue in the Drupal Rector issue queue → . For other issues with the bot, for instance if the issue summary created by the bot is unclear, use the Project analysis issue queue → .

📌 Task
Status

Fixed

Version

1.0

Component

Code

Created by

Project Update Bot

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

  • Comment almost 2 years ago →
    🇦🇺Australia malks 
    +++ b/composer.json
@@ -12,7 +12,7 @@
+    "drupal/core": "^8.7.12 || ^9.0 || ^10.0",

    Because D8 relies on Symfony 3 I don't think we can support D8 any longer and probably should remove the `^8.7.12` requirement. For example `Symfony\Contracts\EventDispatcher\Event` does not exist in Symfony 3.

  • Comment almost 2 years ago →
    🇦🇺Australia malks 
    +++ b/src/Plugin/KeyType/JwtRsKeyType.php
@@ -84,7 +84,9 @@ class JwtRsKeyType extends KeyTypeBase implements KeyPluginFormInterface {
+    if (PHP_VERSION_ID < 80000) {

    I think remove this check and mark it as deprecation with a comment is better as it is still supported in PHP8 but is a nop. @deprecated might mean it gets removed at some stage.

  • Comment almost 2 years ago →
    🇦🇺Australia malks

    @matthew.hallsworth.dpc I think this is mostly fine. As mentioned though in previous comments I don't think this can actually be compatible with D8 any longer as it has a requirement on Symfony 3. Might need maintainers to step in and comment.

  • Comment almost 2 years ago →
    🇦🇺Australia matthew.hallsworth.dpc

    New patch from feedback, thanks @malks for the review :)

    - Have removed D8 since the class callouts are not compatible with Symfony 3
    - Have removed the conditional check for PHP version, since it's a no-op in PHP 8.x

  • Status changed to RTBC almost 2 years ago
  • Comment almost 2 years ago →
    🇦🇺Australia edyuenyw

    @matthew.hallsworth.dpc
    Completed a manual test and it is working fine. I was able to create the test keys and able to add it to the JWT Configuration with no issues.

  • Comment almost 2 years ago →
    System Message
    • pwolanin → committed e171e9cd on 8.x-1.x 
      Issue #3288163 by matthew.hallsworth.dpc, Project Update Bot, lammensj:...
  • Status changed to Fixed almost 2 years ago
  • Comment almost 2 years ago →
    🇺🇸United States pwolanin

    Committing this with the change of removing drupal core requirement from composer.json since the drupal.org composer infra adds it from the .info file

  • Comment almost 2 years ago →
    System Message

    Automatically closed - issue fixed for 2 weeks with no activity.

contrib.social Blog FAQ Discussions
Production build 0.71.5 2024