matthew.hallsworth → created an issue.
@Kristen Pol I'm making this RTBC and I'd like to work with you on a release for this with an eye to helping maintain the module moving forward.
Thanks!
matthew.hallsworth → created an issue.
@rckstr_rohan
Thanks for the testing. That looks like it might be from section themselves, I can't see that error in the codebase.
I wonder if the API has changed?
@rckstr_rohan sorry to hear about your health. Have you had a chance to catch up on this testing?
@rckstr_rohan any updates?
Adding a patch to use until such time as branch is complete.
matthew.hallsworth.dpc → created an issue.
@rckstr_rohan are you able to re-test the current MR and provide testing steps that you performed?
Thanks!
Can a new development branch be created as a breaking change, for D10 only, to rename all the namespaces and module names to match the composer name? This could be 4.x-dev and be D10 only. The branch I have currently can be changed to base off this.
That way, existing installs won't be affected, as part of the upgrade cycle they would have to consider the changes and deal with it accordingly.
As it is, the existing branches don't really work for D9 - we use a branch as the current install on our D9 installs anyway.
Thoughts?
@rckstr_rohan would you be able to give the latest code in the MR another test and leave some dot points in your response as to what you tested and what your outcomes were?
Thanks a lot!
Diff was bad, going to try another one to get to the bottom of this.
Going to try a patch from the PR since I can't seem to get it working for the life of me.
This patch includes all PHPCS fixes so lets see if we can get past the composer issue this way.
Kristen Pol → credited matthew.hallsworth.dpc → .
I've put up a MR to bring this module in line with D10.
- D10 upgrade checker runs over this branch and gives it no issues
- Module installs correctly once other required modules are installed
- Can create a functional config in the UI
Issues as far as I can tell:
- Module has a namespace / machine name mismatch - the module's Drupal machine name is `section_purger` and all the namespaces are `section_purger`, but the module is on D.O. as `section_purge` and the composer install library name is `section_purge`. This is causing big issues when doing such things as automatic module loading in DrupalPod etc. and using PHPUnit. This probably needs fixing
- The test suites (either because of above, or other reasons) refuse to run even in a proper D10 install, due to 'file not found' issues thanks to namespacing.
- Since this module requires a Section.IO account to test, it's difficult to give it a functional test. I am investigating if it is possible to build some PHPUnit mocks for it to test the internal POST requests of the purge methods currently. If I can figure that out, I will add them to this branch.
I would like someone to be able to test this module but it may be difficult. Code review can be done however.
Thanks!
matthew.hallsworth.dpc → made their first commit to this issue’s fork.
matthew.hallsworth.dpc → created an issue.
New patch from feedback, thanks @malks for the review :)
- Have removed D8 since the class callouts are not compatible with Symfony 3
- Have removed the conditional check for PHP version, since it's a no-op in PHP 8.x