Thank you for your patience!
Can you please test the 8.x-dev release to see if your issues are resolved, as detailed below?
1. We added a new setting for spacing between menu links
2. This should be fixed now
3. This should also be fixed now
4. This is by design, we are embracing accessibility guidelines to make your website easier to use by everyone, this includes having links be marked more clearly. You would need custom CSS to reverse this change but we recommend keeping the underlines as it is helpful to your users.
Let me know if it's working out for you in 8.x-dev:
https://www.drupal.org/project/dxpr_theme/releases/8.x-dev →
Hi Jim, can you share a link to the staging site?
Hi Jimm, thanks for your update, it seems a function slipped in that was only added in Drupal 11.3.0 which is no good, we will put out a new dxpr_theme_helper release that is compatible with Drupal 10 as we should be.
Hi Jim,
No worries. In Composer terms “root” simply means your project’s own composer.json file, the one in the Drupal project folder where you run Composer. Even if not locked a specific version, composer will not do a major version update (from 1 to 3) without your explicit permission.
Here is the simplest way to fix this.
-
From your Drupal project root, run the following command. This updates both packages and allows the required major version upgrade.
composer require drupal/dxpr_theme:^8.0 drupal/dxpr_theme_helper:^3.0 -W -
Verify the installed versions.
composer show drupal/dxpr_theme drupal/dxpr_theme_helper -
Run database updates and clear caches.
drush updb -y drush cr
If step 1 still fails, please send me the output of:
composer why drupal/dxpr_theme_helperI can then point out the exact line in your composer.json that is keeping it on version 1.x.
@jimmb please check the release notes, although most of the BC incompatible changes are for 5>8 not 6>8. But still, please double check all issues mentioned in the release notes. You should not uninstall any theme or module when updating to a new version, that will break the update process.
It is important as mentioned in the notes to upgrade dxpr_theme_helper module together with the theme.
Please try https://www.drupal.org/project/dxpr_theme/releases/8.0.0-rc4 → :)
We won't remove the nav colors from the Colors tab because then we cannot control the nav colors form our preset color palettes anymore. The Custom Header Colors (we renamed the fieldset) are meant as an override for power users. The settings should now correctly override all other CSS.
All should be fixed by updating to 8.0.0-rc2, if there is still a problem please provide screenshots and clear steps to reproduce on this issue, thx!
Thanks for your feedback all! We dove into the UX research and have come to side with some of you to bring back hover for the dropdowns!
But there is a caveat:
For complex menu systems, hover is not recommend. In many modern UIs a user expects to need to click or tab to open a collapsible component, like a drop-down menu. It's just that us dinosaurs are used to hover menus in web design and older software.
The recommendation is to "only" support hover for dropdowns specifically in very simple menus in places where hover might be expected to open menus, which is a valid use case in DXPR Theme.
However, because DXPR Theme also supports complex multi-level menus, we implemented automatic switching of hover-support.
Sounds complicated but it is very simple:
Do you have one level of submenus? -> Hover will open drop-downs.
Do you have more than one level of submenus? -> Hover will not open drop-downs.
This update is now pushed to the 8.x-dev release, please test us and let us know your experience. We aim to release a stable 8.0.0 very soon.
To learn more about the menu system and its development, and to test the full demo, you can check out this separate project:
https://github.com/dxpr/bs-dropdown-extended
https://dxpr.github.io/bs-dropdown-extended/
Note on menus: This bug is now fixed and menus will work. In our UX research we als found that using the method is the preferred way as it reduces complexity of the menu, i.e. the top level link has one function: to open the drop down, and is not split in 2 buttons with separate functions.
This should be fixed in 8.x-dev - please try and let me know if it is fixed for you
Regarding the hovering, it is interesting that the world's number one UX research firm recommends click-only menus in their article:
https://www.nngroup.com/articles/menu-design/
But on their own website their menu works with hover, too!
We will work on this today.
Hi mikewiener, thank you for your feature request.
Unlimited flexibility would make it really hard for us to dial in our CSS for every widget inside the settings window, to make it look and work good at "any" size. If we were to move forward with this, at least we would have to define a minimum and maximum width that is acceptable to our UX design team as well as acceptable to our product manager (me) in terms of how many resource we allocate to the development and QA automation of testing the screens at multiple sizes.
For now I will put this on "postponed" because it is not a priority but if there is more interest in this we will consider putting it in a sprint.
What we need in order to get this issue ready is screenshots and context supporting that there is in fact a problem to solve. If you could provide some screenshots, explain the problem, and expectations of a solution that would be great.
Hi jo13sue, we know about the issue and it has already been fixed in 2.8.x, you can update to the latest 2.8.x beta release and that should fix it. Let me know if it works for you!
@catch @longwave
I was wondering if beyond the dll build major changes, whether anyone noticed and tested there are breaking CSS styling changes from CKEditor5 v46. The CKEditor5 team decided to add opinionated CSS styles, affecting things like font-family and font-size within the editor.
In my DXPR Builder module this is especially annoying because we use the inline editor, but in Drupal core's use case this will probably still be a breaking change as users are accustomed to seeing the typography defined in Claro theme or Gin theme in their node form text editors, but now it will be Helvetica/Arial with different font sizes.
I created an issue about the problem here: https://github.com/ckeditor/ckeditor5/issues/19414
Mobile menu colors: Added dedicated mobile_menu_background and mobile_menu_text_color settings under Appearance → DXPR Theme Settings → Header Options → Customize Navigation Colors (same section as other menu color settings).
Mobile menu alignment: Restored in separate commit. Setting available under Appearance → DXPR Theme Settings → Mobile Menu Options → Mobile Menu Alignment with options for left, center, or right alignment. Uses original header_side_align setting name for backward compatibility with 6.x configurations.
Fixed in 8.x-dev! The Content Max-width setting is now working correctly in the latest development version. We removed the hardcoded `max-width: 1600px` values that were overriding the theme setting.
Could you please test with the latest 8.x-dev version and confirm the Content Max-width setting now controls the container width correctly?
Thanks for reporting this!
Fixed in 8.x-dev! The sticky header height adjustment is now working correctly in the latest development version. We corrected the issue where `min-height` was being used instead of `height`, which was preventing proper height adjustments on scroll.
Could you please test with the latest 8.x-dev version and confirm the sticky header height adjusts correctly when scrolling?
Thanks for reporting this!
Fixed in 8.x-dev! The dropdown width setting now works correctly in the latest development version. We've also added an
"Automatic width" option that lets dropdowns fit their content (this is the default behavior).
@leducdubleuet Can you please create a new issue for your bug with steps to reproduce?
This issue is only about supporting menu active trail for views menu links. This is a new feature supported in 8.x that is not supported in 6.x. If you have problems with node menu links or other menu links that would be a different problem requiring a different solution.
I updated the solution in this issue so that parent and child views links are also handled correctly. The fixes referred to here fix a Drupal core issue, not a DXPR Theme regression: https://www.drupal.org/project/drupal/issues/3359511 🐛 [regression] missing menu active trail in Drupal 9.5.9 Needs work
@leducdubleuet it would be great if you could provide bug reports with screenshots for those other issues you mentioned then we will fix them right away
I was also able to reproduce the Views link issue with Olivero, Bartik, and bootstrap5 base theme so seems more like a Drupal core fix. We did put an experimental fix in place which is not committed to the latest 8.x dev version, can you please test it and confirm whether if fixes the Views link problem for you?
https://www.drupal.org/project/dxpr_theme/releases/8.x-dev →
I was not able to reproduce the problem with parent links, they seem to show active status for me. Maybe you meant it did not work with the parent item that was also created by Viewws UI?
Please let me know if the number are back when you update to latest dev:
https://www.drupal.org/project/dxpr_theme/releases/8.x-dev →
And clear Drupal caches. Thanks.
I just released 8.0.0-rc1 so you can have a more stable version. If there are no further bug reports I will probably publish 1.0.0 in about 2 weeks.
Hi Kathc, I will look into your bug report and ensure we get a stable beta release out for DXPR Theme 8.x. This version is already running on DXPR.com and actually fixes usability and accessibility issues with the menu system, therefore we don't want to re-publish 6.x
This Kokoro wrapper can run both in the browser and on the serverL https://github.com/eduardolat/kokoro-web - I've not tried it yet but it looks allright.
@z3cka I tried the one you shared but the demo is offline and I don't see any link to source code on the website.
Fixed in https://www.drupal.org/project/dxpr_builder/releases/2.8.0-alpha27 → and later
Fixed from https://www.drupal.org/project/dxpr_builder/releases/2.8.0-alpha27 → - thanks for the feedback!
Thanks this was a good idea, we added it in https://www.drupal.org/project/dxpr_builder/releases/2.8.0-alpha27 → and it will be in the next stables too.
Fixed in https://www.drupal.org/project/dxpr_builder/releases/2.8.0-alpha27 → and later
We could not find any problem with views but we implemented renderRoot in block handling, this is fixed from https://www.drupal.org/project/dxpr_builder/releases/2.8.0-alpha27 →
Fixed in https://www.drupal.org/project/dxpr_builder/releases/2.8.0-alpha27 → or later
Thx but we use GitHub for managing code quality not GitLab
Fix in 8.x-dev, let me know if it works for you., Thanks!
We launched a new menu system in DXPR Theme that should mark this issue fixed, but feel free to re-open if needed. Thank you for your contributions!
https://www.drupal.org/project/dxpr_theme/releases/8.0.0-alpha1 →
Sorry this is not supported for now and support for other menu systems is not planned. If other users are in need of this feature please comment here.
We launched a new menu system in DXPR Theme that should in any case make this issue obsolete, but feel free to re-open if needed. Thank you for your contributions!
https://www.drupal.org/project/dxpr_theme/releases/8.0.0-alpha1 →
If the problem is still reproducible please tell us what exactly you put in the menu.
We launched a new menu system in DXPR Theme that should in any case make this issue obsolete, but feel free to re-open if needed. Thank you for your contributions!
https://www.drupal.org/project/dxpr_theme/releases/8.0.0-alpha1 →
We launched a new menu system in DXPR Theme that should in any case make this issue obsolete, but feel free to re-open if needed. Thank you for your contributions!
https://www.drupal.org/project/dxpr_theme/releases/8.0.0-alpha1 →
We launched a new menu system in DXPR Theme that should in any case make this issue obsolete, but feel free to re-open if needed. Thank you for your contributions!
https://www.drupal.org/project/dxpr_theme/releases/8.0.0-alpha1 →
We launched a new menu system in DXPR Theme that should in any case make this issue obsolete, but feel free to re-open if needed. Thank you for your contributions!
https://www.drupal.org/project/dxpr_theme/releases/8.0.0-alpha1 →
We launched a new menu system in DXPR Theme that should in any case make this issue obsolete, but feel free to re-open if needed. Thank you for your contributions!
https://www.drupal.org/project/dxpr_theme/releases/8.0.0-alpha1 →
We launched a new menu system in DXPR Theme that should in any case make this issue obsolete, but feel free to re-open if needed.
https://www.drupal.org/project/dxpr_theme/releases/8.0.0-alpha1 →
@lostwolf we will fix this so that you can use the Minimal profile
We are currently working on a new menu system that aims to solve all usability and accessibility systems of the old menu, you can view a prototype here:
https://dxpr.github.io/bs-dropdown-extended/
Let me know if you have a particular issue that is not solved (yet) by this new menu and we can see if we can solve it into the new system.
Because this menu will require many sites to change their theme and possibly menu structure we decided to not merge it into 6.x but rather we'll have to mark a 7.x release as to respect semantic versioning.
We are currently working on a new menu system that aims to solve all usability and accessibility systems of the old menu, you can view a prototype here:
https://dxpr.github.io/bs-dropdown-extended/
Let me know if you have a particular issue that is not solved (yet) by this new menu and we can see if we can solve it into the new system.
In the Drupal integration we will use the separate collapse button that you see in the "Features" top level item in the above demo page.
Because this menu will require many sites to change their theme and possibly menu structure we decided to not merge it into 6.x but rather we'll have to mark a 7.x release as to respect semantic versioning.
We are currently working on a new menu system that aims to solve all usability and accessibility systems of the old menu, you can view a prototype here:
https://dxpr.github.io/bs-dropdown-extended/
Let me know if you have a particular issue that is not solved (yet) by this new menu and we can see if we can solve it into the new system.
Hi, these color values are new and need to be manually set, you could consider exporting the theme settings, copying the color part into an AI Chatbot and asking it to return with empty values filled based on your color scheme so that you can import it.
Otherwise manual setting is the required operation here, I'll make a note in the release notes!
I think this is outdated but please re-open problem returns.
Can you please check if this is still a problem in the latest release?
Thanks, we already implement drupal-check (phpstan) and drupal lint in our github workflows, where we manage our code. It didn't catch the mistake in the info.yml file that may have prompted you to create this issue.
Hi arthur_drupal, implementing custom design systems is on our roadmap! Our roadmap got pushed back due to a focus on AI Page Building features which are almost ready. We will start on design system support towards the end of this year. Because we are adopting Drupal core's Single Directory Components API which I think is still not very mature, we expect this process will take a long time, at least 6 months, as we depend on the SDC ecosystem itself maturing and offering more flexibility and standardization.
Hi Freddy, what scenario prompted you to report this issue? Are you keen on improving performance for editors or content consumers (anaonymous users)?
ok thx for the update, I will create a new project
fixed!
Sorry Im late to the party I see chrisfromredfin had already figured this out, I made this patch yesterday and just remembered I had not posted it yet.