Committed. Thanks both for your patience :)
I think the module should not depend on other "ui" modules. It may be a stopper for people to choose using it.
IMO the fix here should be one of both:
* Try and provide the same functionality without requiring views ui
* Provide this functionality only when views ui is enabled. Otherwise show a notice such as "Enable views ui module in order to see X report"
jonhattan → created an issue.
Sorry it was not this module's fault but other module that adds 'url' cache context to all blocks.
Anyway I think getJson() at https://git.drupalcode.org/project/cookies/-/blob/1.2.x/src/Controller/S... probably doesn't need to cache by url.
jonhattan → created an issue.
Sorry for making more noise. Here's a simplified approach that rely on INFO command instead of CONFIG.
fjgarlin → credited jonhattan → .
Great work. Thank both. Just created a branch and pushed your patches.
I don't like the code duplication, mainly because it needs to be keep updated. May you provide a patch to purge and remove the casting to integer?
Anyway I'll merge this. Thanks again!
jonhattan → made their first commit to this issue’s fork.
Some thoughs:
1. Implement a wildcard purge based on the styles folder: `public://styles/*/filename-path` (not sure now but I think it may be generalized to use the default stream wrapper instead of hardcoding public://)
Note: wildcard purge is not available in all cache/cdn solutions, so it must be a configurable option and fallback to iterating all image styles.
2. I think asking to purge images in despite of they don't exists is better from a performance viewpoint, because a HEAD on inexistent resource in the cache will trigger a call to the backend... ending in a hit to the db server.
3. I think it should be a submodule and avoid mixing image specific stuff with file basic stuff. Perhaps
4. To check file is an image use `Image::isValid` as in:
$image_factory = \Drupal::service('image.factory');
$image = $image_factory->get($file->getFileUri());
if ($image->isValid()) {
// ...
}
jonhattan → created an issue.
jonhattan → created an issue.
jonhattan → created an issue.
jonhattan → changed the visibility of the branch project-update-bot-only to active.
jonhattan → changed the visibility of the branch project-update-bot-only to hidden.
jlbellido → credited jonhattan → .
penyaskito → credited jonhattan → .
Reviewed and tested. It fixed the issue for us. Btw #3039000: Path aliases do not flush → on it's own doesn't help.
Already fixed by committing other pending issues. Thanks!
Committed. Thanks!
I think we need a specific branch for drupal 10.1.x compatibility. In the meanwhile here's the patch updated for advagg 6.0.x.
Merged. Thanks!
📌 Make css/js optimized assets path configurable Fixed added in 10.1.x. Change record: https://www.drupal.org/node/3328126 →