the_g_bomb → credited rembrandx → .
A bit of context about that image JS: some of what it tries to accomplish, is detect when an image is loaded, so it can unset some css used to display a preloader while images are loaded. But also to fix lazy loading images that don’t want to load. I seem to recall cached images not doing what they are supposed to do, for example.
That first thing is not needed to have a functional site, that second thing might not be relevant anymore depending on how lazy loading is implemented in browsers these days, how it works with other image libraries from the modules, …
The logic to detect loaded images, is old and what was available at the time. So could be there’s better ways now to check image being loaded. Or might not be needed anymore at all (just check stuff works when reloading pages please).
Sorry for missing the request on the original issue queue. Nick and I originally created and maintained this module as part of the Dropsolid Rocketship ecosystem and at least I always saw this module as a temporary stopgap for our specific situation, we were eventually gonna work our way out of (especially now with some D10 developments). It is after all just a fork of a module which was also not being followed up on anymore. So we didn't give it as much thought and care as maybe we should have.
But certainly glad to hear someone else is interested in its use. Good to have you there!
Alright, I fixed the big issue, so Storybook works again.
Output from `npm run build-storybook` does still log 'warnings' as 'errors', but that doesn't actually break anything. It's mainly annoying because you don't know if these 'errors' are important or not.
If anyone can figure out how to change that back to 'warnings', I think we're good to go.
Addendum to the noted issues: fixed the dependency stuff, however 1 major issue remains:
can't build Storybook anymore, those npm commands fail with
```
Module build failed (from ./node_modules/@storybook/mdx2-csf/loader.js):
could not parse expression with acorn: Unexpected token
```
There's other output in there, but those are warnings (eg. the one about size limit)
I merged the changes and created a new release (3.10.1), however, I found a bunch of deprecation warnings and 1 version error:
@storybook/mdx2-csf needs to be on 0.0.3 to be compatible with some other storybook addon.
I also downgraded the NodeJS version to v18 (Hydrogen) instead of 19 because I was getting errors on npm install on both 16 and 19 (eg. fibers not building). Things seem to work okay under v18 and that one has long term support (LTS). Also keep in mind that when setting a preferred version, this needs to be done both in package.json ("engines") and in the .nvmrc file.
In short: I tried to fix what was giving errors, but the current dependencies need to be reviewed and updated, especially for Storybook.
rembrandx → made their first commit to this issue’s fork.
rembrandx → made their first commit to this issue’s fork.