- First commit to issue fork.
- First commit to issue fork.
-
rembrandx →
committed ad057231 on 3.x authored by
al0a →
Issue #3334089: Cleanup on the gulp tasks and dependencies
-
rembrandx →
committed ad057231 on 3.x authored by
al0a →
- 🇧🇪Belgium rembrandx
I merged the changes and created a new release (3.10.1), however, I found a bunch of deprecation warnings and 1 version error:
@storybook/mdx2-csf needs to be on 0.0.3 to be compatible with some other storybook addon.
I also downgraded the NodeJS version to v18 (Hydrogen) instead of 19 because I was getting errors on npm install on both 16 and 19 (eg. fibers not building). Things seem to work okay under v18 and that one has long term support (LTS). Also keep in mind that when setting a preferred version, this needs to be done both in package.json ("engines") and in the .nvmrc file.In short: I tried to fix what was giving errors, but the current dependencies need to be reviewed and updated, especially for Storybook.
- 🇧🇪Belgium rembrandx
Addendum to the noted issues: fixed the dependency stuff, however 1 major issue remains:
can't build Storybook anymore, those npm commands fail with
```
Module build failed (from ./node_modules/@storybook/mdx2-csf/loader.js):
could not parse expression with acorn: Unexpected token
```
There's other output in there, but those are warnings (eg. the one about size limit) - 🇧🇪Belgium rembrandx
Alright, I fixed the big issue, so Storybook works again.
Output from `npm run build-storybook` does still log 'warnings' as 'errors', but that doesn't actually break anything. It's mainly annoying because you don't know if these 'errors' are important or not.
If anyone can figure out how to change that back to 'warnings', I think we're good to go.