Cleanup on the gulp tasks and dependencies

Created on 17 January 2023, over 1 year ago
Updated 5 May 2023, about 1 year ago

Problem/Motivation

Currently we have a lot of dependencies to run Gulp and some are outdated and no longer supported in latest node versions.
Some of the helper dependencies are no longer needed, since main module is now more advanced.

We need to cleanup these dependencies and keeping the same features in a way to support latest node versions without any warnings.

Because of the integration of storybook the theme currently has webpack in place, since there is no plan to remove storybook, we can look into using webpack to compile the css and js?
Needs an investigation.

πŸ“Œ Task
Status

Active

Version

3.0

Component

Code

Created by

πŸ‡΅πŸ‡ΉPortugal Jolidog

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

  • First commit to issue fork.
  • First commit to issue fork.
  • πŸ‡§πŸ‡ͺBelgium rembrandx

    I merged the changes and created a new release (3.10.1), however, I found a bunch of deprecation warnings and 1 version error:
    @storybook/mdx2-csf needs to be on 0.0.3 to be compatible with some other storybook addon.
    I also downgraded the NodeJS version to v18 (Hydrogen) instead of 19 because I was getting errors on npm install on both 16 and 19 (eg. fibers not building). Things seem to work okay under v18 and that one has long term support (LTS). Also keep in mind that when setting a preferred version, this needs to be done both in package.json ("engines") and in the .nvmrc file.

    In short: I tried to fix what was giving errors, but the current dependencies need to be reviewed and updated, especially for Storybook.

  • πŸ‡§πŸ‡ͺBelgium rembrandx

    Addendum to the noted issues: fixed the dependency stuff, however 1 major issue remains:
    can't build Storybook anymore, those npm commands fail with
    ```
    Module build failed (from ./node_modules/@storybook/mdx2-csf/loader.js):
    could not parse expression with acorn: Unexpected token
    ```
    There's other output in there, but those are warnings (eg. the one about size limit)

  • πŸ‡§πŸ‡ͺBelgium rembrandx

    Alright, I fixed the big issue, so Storybook works again.
    Output from `npm run build-storybook` does still log 'warnings' as 'errors', but that doesn't actually break anything. It's mainly annoying because you don't know if these 'errors' are important or not.
    If anyone can figure out how to change that back to 'warnings', I think we're good to go.

Production build 0.69.0 2024