Although I'm not sure if it's 100% related, since 10.2.x I'm encountering a similar issue with a translatable image field.
After some debugging I found what could be the problem. Basically while the route enhancer is invoking all of them, the query parameter `resourceVersion` that would trigger the `getRelated` method on the jsonapi controller is failing to propagate the active language on the entity.
Would you care trying my patch and see if that resolves your issue as well?
This is something we definitely need, but in the MR there's too much going on.
Would you care re-rolling the MR on top of 1.x and only for the batch part?
The refactoring proposed is also interesting, but I'd move it in a separate issue, if you wouldn't mind.
Thank you!
Upon further check I realized that most of it was already there. What was missing is the mark complete command which I added in the issue fork
I'm afraid this patch won't solve the issue. By changing the class inheritance you're actually shutting down all pre deploy hook functionality as we were relying on the drush provided class for the implementation and the inheritance to use it.
Since Drush >12 we cannot inherit anymore, but we could still use the method by composing it in our class.
We tested the MR 24 and it works perfectly. We noticed, though, that if a dependency file miss Default content simply ignore them, because the method Graph::searchAndSort from core doesn't add them to the array list returned and sorted.
The only trace of them is found in `vertexes`
We'd like to propose a small, but very useful, patch that adds a log warning when some dependencies are missing.
Yes I confirm patch #39 solves the issue.
Thank you @luxx91 for the improvement.
Sounds a good idea indeed!
Thank you!
I've tested patch #55 and it works perfectly on a drupal 10.1.x release.
I apologize for the inconvenience. I messed up with tag 1.4 and I couldn't amend it.
I've just releases 1.5 which can be pulled with latest Drupal 10 release.
it should be ok now in 1.4.1. sorry about that.
You are right. I didn't check the patch properly, I'm afraid.
Merged and created release 1.4 which is D10 compatible.
Thank you!
This last patch should work. Going to switch it back to need review.
Thanks!
Fixed tests and add one more test to verify that redirect checker returns false when asset path is provided.
I refined a bit your patch (using injected service, but also using a different method for fetching the base path getDirectoryPath()method is defined as abstract method from LocalStream from which all other streams are extended.
basePath, instead, is defined by concrete classes and their implementation of getDirectoryPath calls basePath.
Eventually it's the same, but bit more robust (and usable with s3fs module)
I confirm that patch #10 ✨ Add `drush dcer --bundles` option to limit export Needs review works perfectly.
Thanks!
I confirm the issue on Drupal 10.1 and redirect module.
My scenario is simpler: I have css/js aggregation active and a plain drupal installation.
all files under /sites/default/files/css or js gets redirected to itself appending the query parameters to the existing path until NGINX replies with 414 Request-URI Too Large
LGTM
Rerolled patch #15 to work with 2.16.0
wrong issue.
Rerolled patch #15 to work with version 2.16.0