- Issue created by @Bladedu
- 🇪🇸Spain tahiche
Hi,
After noticing the module didn't work with Drush 12 i went ahead and did a quick test to see if i could fix it.
It seems to be working now. basically changed it to extend DrushCommands isntead of DeployHookCommands which seemed to be the breaking issue with Drush 12. - Status changed to Needs work
7 months ago 1:36pm 22 May 2024 - 🇮🇹Italy Bladedu Italy
I'm afraid this patch won't solve the issue. By changing the class inheritance you're actually shutting down all pre deploy hook functionality as we were relying on the drush provided class for the implementation and the inheritance to use it.
Since Drush >12 we cannot inherit anymore, but we could still use the method by composing it in our class.
- Status changed to Needs review
7 months ago 2:49pm 22 May 2024 - 🇮🇹Italy Bladedu Italy
Upon further check I realized that most of it was already there. What was missing is the mark complete command which I added in the issue fork
- Status changed to Fixed
7 months ago 8:34am 23 May 2024 Automatically closed - issue fixed for 2 weeks with no activity.