Incompatibility with Drush >12.x

Created on 27 December 2023, 11 months ago
Updated 6 June 2024, 5 months ago

Problem/Motivation

starting from Drush 12.x all drush command classes have been made final.

This module is extending from DeployHookCommands.

Proposed resolution

Find another way to make it work without rewriting the whole class (using it like a decorator, for example)

🐛 Bug report
Status

Fixed

Version

1.0

Component

Code

Created by

🇮🇹Italy Bladedu Italy

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

  • Issue created by @Bladedu
  • 🇪🇸Spain tahiche

    Hi,
    After noticing the module didn't work with Drush 12 i went ahead and did a quick test to see if i could fix it.
    It seems to be working now. basically changed it to extend DrushCommands isntead of DeployHookCommands which seemed to be the breaking issue with Drush 12.

  • Status changed to Needs work 6 months ago
  • 🇮🇹Italy Bladedu Italy

    I'm afraid this patch won't solve the issue. By changing the class inheritance you're actually shutting down all pre deploy hook functionality as we were relying on the drush provided class for the implementation and the inheritance to use it.

    Since Drush >12 we cannot inherit anymore, but we could still use the method by composing it in our class.

  • Status changed to Needs review 6 months ago
  • 🇮🇹Italy Bladedu Italy

    Upon further check I realized that most of it was already there. What was missing is the mark complete command which I added in the issue fork

  • Status changed to Fixed 6 months ago
  • Automatically closed - issue fixed for 2 weeks with no activity.

Production build 0.71.5 2024