I appreciate your feedback about our product, and I would like to give you the information that the suggested change will be applied in the next releases that we will make.
Thank you for taking the time to give this feedback to us.
lucm_lw β made their first commit to this issueβs fork.
lucm_lw β made their first commit to this issueβs fork.
This have been fixed in the branch 11.x-1-x and it's already merge
lucm_lw β made their first commit to this issueβs fork.
Already applied to all the files found.
This issue is already fixed on the module page.
This issue is already fixed in the current code.
Hi there,
I already made the possible changes required above.
Some \Drupal calls can't be class injected, so it was already replace where it was possible.
Wait for more feedback on this.
Thanks.
As suggested I applied the recommendations above.
Also as said before, I removed the "__construct" document comments, since they are not mandatory (as said).
phpcs is now throwing that removal as an error, but I assume that should be fine.
The multiple classes that use \Drupal calls were already replaced to use dependency injection, when it was possible.
Wait for more feedbacks
lucm_lw β created an issue.
As requested comments sections was changed and correct.
Wait for more feedback.
Thanks.
Best regards
Hi there,
Would really appreciate any feedback whenever possible, since this becomes a important release to make.
Really grateful for all the feedback that as been given.
Best regards
Hi,
Happy new year to all of you.
Do we have any news about the reviews? Any progress on that?
Thanks.
Best regards
Hi there,
I have performed all the changes above and removed the "__construct" document comments, since they are not mandatory (as said).
phpcs is now throwing that removal as an error, but I assume that should be fine.
Wait for more feedbacks.
Thanks.
Best regards
Hi there,
Had the same issue, and solve it, making sure the following extensions are enabled:
Content Entity Source
Locales Source
Translation Language abilities
Translation Management Core
Good afternoon,
Already fixed all the possible cases for the code standards and also change the namespace to comply with the one provided.
Thanks.
Already fix this library misunderstood, since this is part of this module.
Thanks
Changed all the code and libraries to comply with Drupal standards.
Please review now please.
Thanks
We already change the License from MIT to GPL 2.0.
About the code on library that is not complying with coding standards of Drupal, this is because this is a API communication that will be change to a newer one, very soon. If the changes are needed we can do it, so please let me known.
lucm_lw β created an issue.