@naoi
Thank you for your comment.
When I removed the use statement for OpenStackPasswordGenerator from OpenStackProviderService, I confirmed that the pipeline was working.
I also confirmed that the code works properly.
Could you review it? Thanks.
@naoi
The following warn occurs in phpcs.
--------------------------------------------------------------------------------
FILE ERRORS WARNINGS
--------------------------------------------------------------------------------
...openstack_provider/src/Service/OpenStackProviderService.php 0 1
--------------------------------------------------------------------------------
A TOTAL OF 0 ERRORS AND 1 WARNING WERE FOUND IN 45 FILES
--------------------------------------------------------------------------------
PHPCBF CAN FIX 1 OF THESE SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------
PHP CODE SNIFFER VIOLATION SOURCE SUMMARY
----------------------------------------------------------------------
SOURCE COUNT
----------------------------------------------------------------------
[x] Drupal.Classes.UnusedUseStatement.UnusedUse 1
----------------------------------------------------------------------
A TOTAL OF 1 SNIFF VIOLATION WERE FOUND IN 1 SOURCE
----------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SOURCES AUTOMATICALLY (1 VIOLATIONS IN TOTAL)
----------------------------------------------------------------------
Line 25 of openstack_provider/src/Service/OpenStackProviderService.php is as follows:
https://git.drupalcode.org/issue/facade-3410961/-/blob/f963ee613f9489343...
However, I am actually using "OpenStackPasswordGenerator".
How should I fix it? Thanks.
@yas
I fixed the following.
- Add a newline to the end of the file
- Changed the variable name of the string that is allowed to be used to "allowedCharacters"
Could you review it? Thanks.
@yas
I changed openstack password generation policy.
Could you review it? Thanks.
kentaro.hayashi → created an issue.
@yas
Could you review it? Thanks.
kentaro.hayashi → changed the visibility of the branch 3406669-take-a-screenshot to active.
kentaro.hayashi → changed the visibility of the branch 3406669-take-a-screenshot to hidden.
kentaro.hayashi → created an issue.
@naoi
Could you review it? Thanks.
kentaro.hayashi → created an issue.
@yas
Could you review it? Thanks.