Change password generation rules

@yas

I changed openstack password generation policy.
Could you review it? Thanks.

@kentaro.hayashi

Can you please create the MR? Thanks!

@yas

I fixed the following.

• Add a newline to the end of the file
• Changed the variable name of the string that is allowed to be used to "allowedCharacters"

Could you review it? Thanks.

@kentaro.hayashi

Can you please check the phpcs errors?
→ https://git.drupalcode.org/issue/facade-3410961/-/jobs/645535

Thanks

@naoi

The following warn occurs in phpcs.

--------------------------------------------------------------------------------
FILE                                                            ERRORS  WARNINGS
--------------------------------------------------------------------------------
...openstack_provider/src/Service/OpenStackProviderService.php  0       1
--------------------------------------------------------------------------------
A TOTAL OF 0 ERRORS AND 1 WARNING WERE FOUND IN 45 FILES
--------------------------------------------------------------------------------
PHPCBF CAN FIX 1 OF THESE SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------
PHP CODE SNIFFER VIOLATION SOURCE SUMMARY
----------------------------------------------------------------------
    SOURCE                                                       COUNT
----------------------------------------------------------------------
[x] Drupal.Classes.UnusedUseStatement.UnusedUse                  1
----------------------------------------------------------------------
A TOTAL OF 1 SNIFF VIOLATION WERE FOUND IN 1 SOURCE
----------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SOURCES AUTOMATICALLY (1 VIOLATIONS IN TOTAL)
----------------------------------------------------------------------

Line 25 of openstack_provider/src/Service/OpenStackProviderService.php is as follows:
https://git.drupalcode.org/issue/facade-3410961/-/blob/f963ee613f9489343...

However, I am actually using "OpenStackPasswordGenerator".
How should I fix it? Thanks.

@kentaro.hayashi

Since both OpenStackPasswordGenerator and OpenStackProviderService are in the same directory, so can we simply remove the following line?

diff --git a/modules/tenants/openstack_provider/src/Service/OpenStackProviderService.php b/modules/tenants/openstack_provider/src/Service/OpenStackProviderService.php
index 608c27d..abb8778 100644
--- a/modules/tenants/openstack_provider/src/Service/OpenStackProviderService.php
+++ b/modules/tenants/openstack_provider/src/Service/OpenStackProviderService.php
@@ -22,7 +22,6 @@ use Drupal\facade\Entity\TenantInterface;
 use Drupal\openstack\Service\OpenStackServiceFactoryInterface;
 use Drupal\openstack_provider\Entity\OpenStackTenantProject;
 use Drupal\openstack_provider\Entity\OpenStackTenantProjectInterface;
-use Drupal\openstack_provider\Service\OpenStackPasswordGenerator;
 use GuzzleHttp\ClientInterface;
 use GuzzleHttp\Exception\GuzzleException;
 use Symfony\Component\DependencyInjection\ContainerInterface;

@naoi

Thank you for your comment.
When I removed the use statement for OpenStackPasswordGenerator from OpenStackProviderService, I confirmed that the pipeline was working.
I also confirmed that the code works properly.
Could you review it? Thanks.

@kentaro.hayashi

Thank you for the update. I'll merge the patch to 1.0.x, and close this issue as Fixed.

@hayashi.kentaro

Please keep the status Fixed until the status will be automatically changed to Closed (fixed) after two weeks from the Fixed date. See also: https://www.drupal.org/docs/develop/issues/fields-and-other-parts-of-an-... →

Automatically closed - issue fixed for 2 weeks with no activity.