I apologize for the long delay.
I've fixed PHP version for the module.
Hello, thank you for the review.
I've run linter and i can reproduce this error :
ERROR | [x] End of line character is invalid; expected "\n" but found "\r\n"
Files seems to have correct end of line (LF : \n)
I've commit some changes which fix these errors :
- Only string literals should be passed to t() where possible
- Only string literals should be passed to t() where possible
- Expected 1 newline at end of file; 2 found
Hello, thanks you for the review.
I've run linter and i can reproduce this error :
ERROR | [x] End of line character is invalid; expected "\n" but found "\r\n"
Files seems to have correct end of line (LF : \n)
I've commit some changes which fix these errors :
- Only string literals should be passed to t() where possible
- Only string literals should be passed to t() where possible
- Expected 1 newline at end of file; 2 found
Hello, thank you for your review.
I've run linters and I can't reproduce this error :
ERROR | [x] End of line character is invalid; expected "\n" but found "\r\n"
Files seems to have correct end of line (LF : \n)
I've push a new commit which fix others errors like :
- A comma should follow the last multiline array item. Found: )
- Only string literals should be passed to t() where possible
- Expected 1 newline at end of file; 2 found
Thank you for your reply.
I've created a new branch 1.0.x which is my default one.
PHPCS with Drupal and DrupalPractice standard linters have been run successfully.