- Issue created by @Kgaut
- 🇫🇷France S3b0uN3t Nantes
Hi @kgaut,
Color management in dark mode is actually not interpreted correctly.
Your scenario will work well with Gin but the problem may arise for other dark themes.Also, are we sure that it is only necessary to declare this property for everything to work correctly?
- 🇫🇷France S3b0uN3t Nantes
I think the best approach would be to use CkEditor 5's CSS variables as much as possible: https://ckeditor.com/docs/ckeditor5/latest/getting-started/setup/css.html#customizing-the-editors-look.
Example for the lark theme (used for dark mode): https://ckeditor.com/docs/ckeditor5/latest/framework/deep-dive/ui/theme-customization.html#customization-with-css-variables
- 🇫🇷France S3b0uN3t Nantes
For a simple change I prupose to add these lines in
css/ckeditor.css
:/* Manage "Gin" theme dark mode. */ .gin--dark-mode .ck-content { --grey-200-850: #cecece; --grey-200-850-hover: #a8a8a8; --grey-200-850-active: #939393; }
Extracted from DSFR library dark mode :
- File
dist/scheme/scheme.css
- Selector
:root[data-fr-theme=dark]
- File