🇫🇷France @NathLL

Sorry, I've maybe created this issue a bit quickly.
After working on tests, I realized that I may have not fully understood how this code works.

Please can someone check this. Thanks.

Ok, thanks for the clarification.

I'm currently working on updating tests. So I'll port my change on 11.x then working back on update tests.

nathll → created an issue.

I pushed a branch (in fork issue) for chosen 3.0.x : https://git.drupalcode.org/issue/chosen-3493187/-/tree/3493187-3-0-x-dro...
(I'm new to contributing so I'm not sure it's the good way to do it, please let me know it. Thanks).

I made some changes. I think it could be better to check the space above and below the container to determine if the dropdown should be display above or below.

I also found an issue in your fix. You add class "dropdown-above" on the container and add style="bottom: XXXpx" (XXX is the element height) one the element (.chose-drop). But you never remove them. So if we resize the windows without reload the page then the display is not changed. So if there is no more space above, it stills display above which is not good.

Here my code :
chosen/js/chosen.js line 105

$element.on('chosen:showing_dropdown', function () {
  var $container = $(this).next('.chosen-container');
  var container_position = $container.offset();
  var container_height = $container.height();
  
  var $chosen_dropdown = $container.find('.chosen-drop');
  
  var scroll_top = $(window).scrollTop();
  var window_height = $(window).height();
  
  var space_above = container_position.top - scroll_top;
  var space_below = (scroll_top + window_height) - (container_position.top + container_height);
  
  if (space_above > space_below) {
    $container.addClass('dropdown-above');
    $chosen_dropdown.css('bottom', $container.height());
  } else {
    $container.removeClass('dropdown-above');
    $chosen_dropdown.css('bottom', '');
  }
});

My changes are on chosen v3.0.x but can easily be applied on chosen 4.0.x (see my patch. WARNING : I have not tested it, but this code is working for 3.0.x and changes are little from what the original fix proposes).

WARNING : This code doesn't just has an impact on VBO dropdown but it impacts all dropdowns using chosen

I have the same problem with Gin too.
I have a questions :
- Does this fix change the dropdown from above to under if there is the place to display it under ?
- What's the behavior if there is no more place above but enough under ? Does it change from above to under automatically or if I close and re-open it ?

I have try it on v3.0.x and seems to work, but the dropdown is fixed above whatever I do.
Thanks for helping.

nathll → changed the visibility of the branch NathLL-work-branch to hidden.

nathll → created an issue.

Hi,

The automated patch generated by Drupal Rector works fine.
Have you planned to release the Drupal 10 compatible version of your module ?

Thanks.

NathLL → changed the visibility of the branch 3464636-not-compatible-with-drupal-10-3 to hidden.

Please do not take this issue in consideration it was a mistake from me. Sorry.

NathLL → created an issue.

NathLL → created an issue.

NathLL → created an issue.