Account created on 30 August 2022, almost 2 years ago
#

Merge Requests

Recent comments

I've removed the need for PHPUnit\Asynchronicity.
And updated the unit tests.

Hi, nice work for the recent updates of this module!

I think that elasticsearch_connector should be able to validate all tests from BackendTestBase.

My changes:
- call the parent testBackend
- fix the code so that all of these tests pass

Todo:
- Fix the unit tests with the changes I made
- Add PHPUnit\Asynchronicity back

Some notes on my changes:
- Some issues on the results were due to the fuzziness, I think a new issue for testing this features could be interesting
- The tests from searchSuccess where duplicate form the parent, I remove them

I would love your feedback.

Done :

  • Add back the default search_api backend tests : Drupal\Tests\search_api\Kernel\BackendTestBase
  • Fix the SearchBuilder to pass the tests.
  • Add .gitlab-ci.yml (with elasticsearch docker dependency) to run the tests the drupalci.yml will be deprecated.
  • Some minor code cleaning.

This version should be compatible with drupal 9 and 10 and Elasticsearch 7 and 8.

Production build 0.69.0 2024