- Issue created by @sokru
- Status changed to Active
8 months ago 5:42am 12 March 2024 - First commit to issue fork.
- Merge request !42Issue #3426827: Figure out why test results differ from search_api_opensearch → (Merged) created by hexaki
- Open on Drupal.org →Core: 10.2.1 + Environment: PHP 8.1 & MySQL 5.7last update
8 months ago Waiting for branch to pass Hi, nice work for the recent updates of this module!
I think that elasticsearch_connector should be able to validate all tests from BackendTestBase.
My changes:
- call the parenttestBackend
- fix the code so that all of these tests passTodo:
- Fix the unit tests with the changes I made
- Add PHPUnit\Asynchronicity backSome notes on my changes:
- Some issues on the results were due to the fuzziness, I think a new issue for testing this features could be interesting
- The tests fromsearchSuccess
where duplicate form the parent, I remove themI would love your feedback.
- Open on Drupal.org →Core: 10.2.1 + Environment: PHP 8.1 & MySQL 5.7last update
8 months ago Waiting for branch to pass - Open on Drupal.org →Core: 10.2.1 + Environment: PHP 8.1 & MySQL 5.7last update
8 months ago Waiting for branch to pass - Open on Drupal.org →Core: 10.2.1 + Environment: PHP 8.1 & MySQL 5.7last update
8 months ago Waiting for branch to pass - Open on Drupal.org →Core: 10.2.1 + Environment: PHP 8.1 & MySQL 5.7last update
8 months ago Waiting for branch to pass - Status changed to Needs review
8 months ago 10:02am 15 March 2024 I've removed the need for PHPUnit\Asynchronicity.
And updated the unit tests.- 🇨🇦Canada mparker17 UTC-4
Adding 🌱 Plan for 8.0.0-alpha release Active as a parent issue.
- Open on Drupal.org →Core: 10.2.1 + Environment: PHP 8.1 & MySQL 5.7last update
8 months ago Waiting for branch to pass - Open on Drupal.org →Core: 10.2.1 + Environment: PHP 8.1 & MySQL 5.7last update
8 months ago Waiting for branch to pass - Status changed to RTBC
8 months ago 1:14pm 22 March 2024 - 🇫🇮Finland sokru
Thanks @hexaki! I have looked the MR few times, on the first glance it looked like the changes where totally out-of-scope, but after more reading they make totally sense, excellent work! Its good that we're be able to also cover the parent
testBackend
! We should include that as release highlights for 8.0.0.Only minor nitpick about the quotes,
Drupal does not have a hard standard for the use of single quotes vs. double quotes. Where possible, keep consistency within each module, and respect the personal style of other developers.
With that caveat in mind, single quote strings should be used by default.https://www.drupal.org/docs/develop/standards/php/php-coding-standards#:... → .
I've set the status RTBC, does not hurt if anyone else could also check the changes, I'll re-read the changes once more before committing.
- 🇨🇦Canada mparker17 UTC-4
This looks good to me as well. Excellent work, @hexaki: thank you very much!
- Open on Drupal.org →Core: 10.2.1 + Environment: PHP 8.1 & MySQL 5.7last update
8 months ago Waiting for branch to pass - Status changed to Fixed
8 months ago 11:50am 24 March 2024 - 🇫🇮Finland sokru
Changed few double quotation marks, but changing all of them would make Elasticsearch tests to fail.
Automatically closed - issue fixed for 2 weeks with no activity.