Figure out why test results differ from search_api_opensearch

Created on 9 March 2024, 8 months ago
Updated 7 April 2024, 7 months ago

Problem/Motivation

tests/src/Kernel/ElasticSearchBackendTest.php has few @todo, since the tests differ from search_api_opensearch (https://git.drupalcode.org/project/search_api_opensearch/-/blob/2.x/test...), figure out why and adjust the commented tests to pass.

See the comments on https://git.drupalcode.org/project/elasticsearch_connector/-/merge_reque...

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

📌 Task
Status

Fixed

Version

8.0

Component

Code

Created by

🇫🇮Finland sokru

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

  • Issue created by @sokru
  • Status changed to Active 8 months ago
  • First commit to issue fork.
  • Open on Drupal.org →
    Core: 10.2.1 + Environment: PHP 8.1 & MySQL 5.7
    last update 8 months ago
    Waiting for branch to pass
  • Pipeline finished with Failed
    8 months ago
    Total: 238s
    #119682
  • Hi, nice work for the recent updates of this module!

    I think that elasticsearch_connector should be able to validate all tests from BackendTestBase.

    My changes:
    - call the parent testBackend
    - fix the code so that all of these tests pass

    Todo:
    - Fix the unit tests with the changes I made
    - Add PHPUnit\Asynchronicity back

    Some notes on my changes:
    - Some issues on the results were due to the fuzziness, I think a new issue for testing this features could be interesting
    - The tests from searchSuccess where duplicate form the parent, I remove them

    I would love your feedback.

  • Open on Drupal.org →
    Core: 10.2.1 + Environment: PHP 8.1 & MySQL 5.7
    last update 8 months ago
    Waiting for branch to pass
  • Pipeline finished with Failed
    8 months ago
    Total: 258s
    #119755
  • Open on Drupal.org →
    Core: 10.2.1 + Environment: PHP 8.1 & MySQL 5.7
    last update 8 months ago
    Waiting for branch to pass
  • Pipeline finished with Success
    8 months ago
    Total: 249s
    #119779
  • Open on Drupal.org →
    Core: 10.2.1 + Environment: PHP 8.1 & MySQL 5.7
    last update 8 months ago
    Waiting for branch to pass
  • Pipeline finished with Success
    8 months ago
    Total: 197s
    #119842
  • Open on Drupal.org →
    Core: 10.2.1 + Environment: PHP 8.1 & MySQL 5.7
    last update 8 months ago
    Waiting for branch to pass
  • Pipeline finished with Success
    8 months ago
    Total: 199s
    #119865
  • Status changed to Needs review 8 months ago
  • I've removed the need for PHPUnit\Asynchronicity.
    And updated the unit tests.

  • 🇨🇦Canada mparker17 UTC-4

    Adding 🌱 Plan for 8.0.0-alpha release Active as a parent issue.

  • Open on Drupal.org →
    Core: 10.2.1 + Environment: PHP 8.1 & MySQL 5.7
    last update 8 months ago
    Waiting for branch to pass
  • Pipeline finished with Success
    8 months ago
    Total: 178s
    #121424
  • Open on Drupal.org →
    Core: 10.2.1 + Environment: PHP 8.1 & MySQL 5.7
    last update 8 months ago
    Waiting for branch to pass
  • Pipeline finished with Success
    8 months ago
    Total: 170s
    #121589
  • Status changed to RTBC 8 months ago
  • 🇫🇮Finland sokru

    Thanks @hexaki! I have looked the MR few times, on the first glance it looked like the changes where totally out-of-scope, but after more reading they make totally sense, excellent work! Its good that we're be able to also cover the parent testBackend! We should include that as release highlights for 8.0.0.

    Only minor nitpick about the quotes,

    Drupal does not have a hard standard for the use of single quotes vs. double quotes. Where possible, keep consistency within each module, and respect the personal style of other developers.
    With that caveat in mind, single quote strings should be used by default.

    https://www.drupal.org/docs/develop/standards/php/php-coding-standards#:... .

    I've set the status RTBC, does not hurt if anyone else could also check the changes, I'll re-read the changes once more before committing.

  • 🇨🇦Canada mparker17 UTC-4

    This looks good to me as well. Excellent work, @hexaki: thank you very much!

  • Open on Drupal.org →
    Core: 10.2.1 + Environment: PHP 8.1 & MySQL 5.7
    last update 8 months ago
    Waiting for branch to pass
    • sokru committed cecba8c2 on 8.0.x authored by hexaki
      Issue #3426827 by hexaki, sokru, mparker17: Figure out why test results...
  • Status changed to Fixed 8 months ago
  • 🇫🇮Finland sokru

    Changed few double quotation marks, but changing all of them would make Elasticsearch tests to fail.

  • Automatically closed - issue fixed for 2 weeks with no activity.

Production build 0.71.5 2024