@van.dordafog

removing the "fa-" prefix on save fixes both the value in Edit as well es shows the correct icon from the formatter

van.dordafog → created an issue.

changes to dependent_filters don't get saved since "options" get overwritten.
patch towards commit 3bfbe676:

diff --git a/src/Plugin/views/filter/ViewsDependentFilter.php b/src/Plugin/views/filter/ViewsDependentFilter.php
index 51ce85365..b5af9f9de 100644
--- a/src/Plugin/views/filter/ViewsDependentFilter.php
+++ b/src/Plugin/views/filter/ViewsDependentFilter.php
@@ -228,6 +228,7 @@ public function submitOptionsForm(&$form, FormStateInterface $form_state) {
         $controller_values = array_map('trim', explode(',', $controller_values));
         $controller_values = array_combine($controller_values, $controller_values);
         $this->options["controller_values"] = $controller_values;
+        $this->options["dependent_filters"] = $form_state->getValue('options')['dependent_filters'];
         $form_state->setValue('options', $this->options);
       }
     }

van.dordafog → created an issue.

Excuse the wording. The idea would be to guarantee that no external assets are being loaded. With a relatively simple check on all module libraries, instead of having to analyze the config. I think there's GDPR aspect to this but probably the main the concern is a supply chain attack

van.dordafog → created an issue.

set $settings['swiper_formatter__forbid_remote'] = TRUE; in settings.php

van.dordafog → created an issue.

probably more a workaround that a fix

van.dordafog → created an issue.

#58 doesn't apply because of windows lineend char

rerolled for 10.3.10, didn't include the tests, since expecting this to get a more general solution

depending on how content/interface language detection is configured and whether content is translated in the detected language
the check by langcode might be unsuccessful.
checking if the initial_path ends with '/media/oembed' seems more reliable:

diff --git a/src/Utility/KlaroHelper.php b/src/Utility/KlaroHelper.php
index ef408e3..14e4f03 100644
--- a/src/Utility/KlaroHelper.php
+++ b/src/Utility/KlaroHelper.php
@@ -811,8 +811,6 @@ class KlaroHelper {
       }
     }
 
-    $langcode = $this->languageManager->getCurrentLanguage()->getId();
-
     foreach ($dom->getElementsByTagName('iframe') as $iframe) {
       if ($iframe->hasAttribute('data-src') && $iframe->hasAttribute('data-name')) {
         continue;
@@ -821,7 +819,7 @@ class KlaroHelper {
       $initial_path = parse_url($initial_src, PHP_URL_PATH);
 
       // If remote-video matchKlaroApp against url parameter.
-      if ((strpos($initial_path, '/media/oembed') === 0) || (strpos($initial_path, '/' . $langcode . '/media/oembed') === 0)) {
+      if (str_ends_with($initial_path, '/media/oembed')) {
         parse_str(parse_url($initial_src, PHP_URL_QUERY), $params);
         $found_klaro_app = $this->matchKlaroApp($params['url']);
       }

tested - configured translations are correctly used

van.dordafog → created an issue.

it's still necessary for rc7, that's why the patch reroll

@sascha_meissner the easiest way to test this would be to change the config text in "Texts > App Item > PURPOSE > Singular form" to something noticeably different. Then check in frontend list of apps - the "purpose" text under each app will not have changed.

reroll for rc7

patch to show title before section also in onecol

this doesn't migrate arguments and might be incomplete in other ways

van.dordafog → created an issue.

this works when migrating from D7 paragraphs (not with field collection).
it also improves the dependency requirements between the migration but might not fix the erroneously created stubs

van.dordafog → created an issue.

reroll #13 for Drupal 10 according to #25
Will not work with Drupal 9

this patch just renames the klaro.texts app to service wherever it's used in code and adds an update hook to change the existing config.
might have issues on sites where those texts where never translated in BE (not tested)

van.dordafog → created an issue.

yes, as reported: drupal 10.1.4

van.dordafog → created an issue.

one line fix

van.dordafog → created an issue.