Account created on 19 January 2022, almost 3 years ago
#

Merge Requests

Recent comments

πŸ‡¨πŸ‡΄Colombia jasonac91

I've been reviewing the issue described here, but I find that there is some critical information missing that's necessary to replicate and validate the problem effectively. Could you please provide more detailed steps on how to reproduce the issue, as well as specify the environment settings such as software version, configurations, etc.? This additional information would greatly help in understanding and addressing the issue more accurately.

πŸ‡¨πŸ‡΄Colombia jasonac91

This patch addresses an issue where the access() method could potentially return a boolean instead of an expected AccessResult object in the ViewsBulkOperationsActionProcessor class. This was causing a fatal error ("Call to a member function isAllowed() on bool") when attempting to call isAllowed() on what was assumed to be an AccessResult object but was actually a boolean value.

The provided solution adds a check to ensure that the $accessResult variable is indeed an object and specifically that it possesses the isAllowed() method before attempting to call it. This check prevents the fatal error by verifying the type and method existence:

The patch first checks if $accessResult is an object and if it has the method isAllowed using PHP's is_object() and method_exists().
If these checks pass, it processes to verify if the access is allowed.
If $accessResult is not an object or does not have the isAllowed() method, it logs an error stating that the access result is not a valid AccessResult object. This helps in identifying configuration or code issues that might be causing unexpected return types.
By implementing this, we ensure the robustness of the process() function in handling cases where the action might not adhere to the expected return type conventions. This change is crucial for maintaining the stability and reliability of bulk operations within Views Bulk Operations, especially in complex environments where different actions might be configured to return non-standard access results.

This patch is attached for review and testing. It has been tested in my local environment where the issue was replicated and verified that the patch resolves the problem without affecting the existing functionalities.

πŸ‡¨πŸ‡΄Colombia jasonac91

None of this works, with any version after 4.1.0

πŸ‡¨πŸ‡΄Colombia jasonac91

None of this works, with any version after 4.1.0

πŸ‡¨πŸ‡΄Colombia jasonac91

Hello,

I'm looking to understand more about the issue with the Field Group module not implementing hook_requirements. Here are a few questions to help clarify the situation:

Could you provide some insight into what specific functionalities are affected by the absence of hook_requirements in the Field Group module? Does this impact the module's stability or functionality in any significant way?

Is the error message Requirement function field_group_requirements not found affecting any other operational aspects of the site, or is it isolated to when this specific sensor is enabled in the monitoring settings?

What is the primary motivation for implementing hook_requirements in the Field Group module? Is it primarily for compliance with best practices, or are there specific scenarios where the absence of this hook leads to issues in system monitoring?

How frequently do users enable the 'Core Requirements' sensor for the Field Group module? Is this an essential part of typical site monitoring, or is it used in specific troubleshooting scenarios?

Are there any temporary workarounds that have been identified, or is the implementation of hook_requirements the only proposed solution?

Thank you for your assistance in resolving these queries.

πŸ‡¨πŸ‡΄Colombia jasonac91

Hello,

I appreciate the efforts to streamline the integration of Media Entity modules for Facebook and Instagram. However, it's important to consider the accessibility differences between the two platforms, especially for new features like embedding Instagram reels or videos. Unlike Facebook, where many features are more publicly accessible, Instagram often requires more specific permissions to access and embed media such as reels or videos. This might necessitate keeping separate modules or at least clearly distinguishing the permissions and access requirements within a unified module to avoid confusion and ensure that users are aware of these limitations when attempting to embed content from Instagram.

Best regards, Jason

πŸ‡¨πŸ‡΄Colombia jasonac91

While the proposed solution seems promising, it would be helpful to have more detailed information regarding the specific use cases and testing scenarios where combining AND and OR logic in contextual filters would be applied. Could you please provide some examples or documentation that illustrates the expected behavior in various contexts? This information would be crucial for fully understanding the potential impact and implementation challenges of this feature.

πŸ‡¨πŸ‡΄Colombia jasonac91

jasonac91 β†’ made their first commit to this issue’s fork.

πŸ‡¨πŸ‡΄Colombia jasonac91

I haven't found any simpler solution than commenting out that Drupal set message, but there should be something else that can be done.

πŸ‡¨πŸ‡΄Colombia jasonac91

I was debugging in order to add the attachments. Sendgrid replaces the attachments that are sent from any part of Drupal. I don't understand why, but I tried various structures to get it to recognize the attachments. This one worked for me, but it involves creating a temporary file. It works for my website, and I hope this temporary solution can help for improvement.

πŸ‡¨πŸ‡΄Colombia jasonac91

The version of the Mailchimp library has been changed.

πŸ‡¨πŸ‡΄Colombia jasonac91

If the duplicated functions have identical names, you can try renaming one of the functions in one of the modules to avoid the conflict.

πŸ‡¨πŸ‡΄Colombia jasonac91

Jasonac91 β†’ created an issue.

Production build 0.71.5 2024