🇺🇸United States @nm63282

@Vishal,

Can we move this forward?

Thanks

I've attached a patch that address the issues and is pretty minimal. But recurring_events can be heavily relied on and by sites with lots of events traffic so it'd be helpful getting review from another maintainer.

Here a summary of the changes, which are within recurring_Events_registration:

1. Change hook `eventseries_insert` to `eventinstance_insert`
2. Change criteria in `eventseries_update` to simple yes/ no
3. Do not empty `reminder_sent`

I'll mark this as Needs review.

Thanks your clear write up and for the report @phillamb168. I can reproduce the same, although it sounds like you found workarounds.

Here's my write up to help drafting a pull request. I should be able to draft something shortly.

1) Clicking Add instance on a series creates an instance with `reminder_date` empty
2) When `reminder_date` changes `reminder_sent` is emptied
3) If series dates changes but reminder options did not, instances are recreated without a `reminder_date` (It's expected Instances are recreated when series dates change)

I was just testing and see it on a core field--

To repro:
1. Disable smart_date, multiple_fields_remove_button.
2. Create two new fields:
2.a. Date and time (Date, multiple)
2.b. Date and time (Timestamp, multiple)

Add multiple values to each field on a node, then save it.
Edit the node and try removing values.

Result:
1. Can remove all Date values
2. Cannot remove all Timestamp values

I could be wrong but, looks like core (maybe multiple_fields_remove_button too) need an update. I'll try and look more.

Versions: Drupal version : 10.4.5

1.x branch updated; marking Ready for review.

Thank you for review Vishal.

I've made those updates:
- Branch `develop` deleted;
- info.yml updated
- .module comment updated.

These changes appear in tag 1.0.1 [ https://git.drupalcode.org/project/decorative_images/-/tags/1.0.1 ]

We have release branch (not tag) `1.x`. What numbering do you recommend if tag `1.2.0` already exists?

ll66382 → created an issue.

ll66382 → created an issue.

https://www.drupal.org/project/drupal/issues/3347021#comment-15967244 💬 CKEditor 5 Media Embed alignment options does not work Closed: cannot reproduce And @megan_m 's solution worked for me:

- Limit allowed HTML tags and correct faulty HTML
- Correct faulty and chopped off HTML

Also Embed media near the bottom so Media links are not removed per https://www.drupal.org/project/drupal/issues/3075527#comment-15604529 🐛 Adding links around embedded media through CKEditor might lead to invalid/complex markup when rendered Active

I have recurring_events on a couple of sites now although, I have to make sure I have databases for them. I have contributed patches and code for recurring_events. I'd be glad to help out here and there. Could you go ahead and add me? If yes I'll try watching the queue to add help or comments where possible.

ll66382 → created an issue.

ll66382 → created an issue.

Has there been any discussion of adding a "Decorative" checkbox to images?

Could I be added as a contributor/ co-maintainer helper of this guide? I'm routinely using API's as a part of a large portfolio of sites. I'd be glad to verify or make suggestions to the guide's materials when time allows. 

nm63282 → created an issue.

nm63282 → created an issue.

nm63282 → created an issue.

Move UI tips/ instructions to bottom. 

Improve page title.

Cleanup. 

Improve code documentation. 

Improve testing instructions.

Add source code.

Improve clarity.

Here is a sample plugin for above.

Note it would break complex permissions, for example block rules below or beside allow rules.

web/modules/custom/zzz/src/Plugin/ImcePlugin/ZzzImceFolders.php

namespace Drupal\zzz\Plugin\ImcePlugin;


use Drupal\Core\Session\AccountProxyInterface;
use Drupal\imce\Imce;
use Drupal\imce\ImcePluginBase;

/**
 * Custom IMCE folder perms merge.
 *
 * @ImcePlugin(
 *   id = "zzz_imce_folders",
 *   label = "IMCE ZZZ Folders",
 *   weight = 10,
 * )
 *
 * Explain.
 */
class ZzzImceFolders extends ImcePluginBase {

  /**
   * {@inheritdoc}
   */
  public function processUserConf(array &$conf, AccountProxyInterface $user) {

    // Skip administrators.
    if ($user->hasPermission("administer imce")) {
      return;
    }

    // Skip admin roles.
    if (array_intersect($user->getRoles(), [
      'administrator',
      'custom_client_admin',
    ])) {
      return;
    }

    // Get imce settings.
    $settings = \Drupal::config('imce.settings');
    $imce_roles = $settings->get('roles_profiles');

    // Get user roles, from more permissive to less permissive.
    $user_roles = array_reverse(array_flip($user->getRoles()));
    $user_imce_roles = array_keys(array_intersect_key($imce_roles, $user_roles));

    // Get storage.
    $scheme = \Drupal::config('system.file')->get('default_scheme');
    $storage = \Drupal::entityTypeManager()->getStorage('imce_profile');

    // Get folders for each role.
    foreach ($user_imce_roles as $id) {
      if ($profile = $storage->load($imce_roles[$id][$scheme])) {
        if ($folders = $profile->getConf('folders', [])) {
          $processed = Imce::processUserFolders($folders, $user);
          $conf['folders'][$id] = $processed;
        }
      }
    }
  }

}

This still occurs on 3.0.0-beta8.

Oddly, the patch still applies too.

looks like the issue may be multiple dialogs getting inserted.

nifsight → created an issue.