🇻🇳Vietnam @ducviethaboo

ducviethaboo → created an issue.

I found the issue why they changed from mb_convert_encoding() to iconv() (https://git.drupalcode.org/project/openai/-/merge_requests/81/diffs?commit_id=999a1d3b2fe30ec2daa6a2a43c38d4fbfe98ea79). But it will cause error in my case like comment in #5.
I resolved this problem by following way:

-    $dom->loadHTML(htmlspecialchars_decode(iconv('UTF-8', 'ISO-8859-1', htmlentities($text, ENT_COMPAT, 'UTF-8')), ENT_QUOTES));
+    $dom->loadHTML(htmlspecialchars_decode(mb_convert_encoding(htmlentities($text, ENT_COMPAT, 'UTF-8'), 'ISO-8859-1', 'UTF-8'), ENT_QUOTES));

I just ran into this issue with myself as well. My site is a multilingual. In case the body contains Japanese characters, something like "役質ド定本イロ統転学ぱ歳" will get the same error. I think the iconv() can be replaced with mb_convert_encoding(). After researching, I found that the two functions have similar functions.

i tried the following, and it seemed to work for the class attribute for the br tag

editor.model.schema.extend( 'softBreak', { allowAttributes: [ 'brClass' ] } )
editor.conversion.attributeToAttribute( {
        model: 'brClass',
        view: 'class'
      } );

3398223-support-hr-tag-classes works perfectly with hr tag. I'm trying to do the same thing with br tag, but it cannot implement adding classes to br tag. I tried 2 ways:
1. Install https://www.drupal.org/project/ckeditor_breaktag → , add support for an "brClass" similar to "hrClass"
2. Add allow for br tag, following https://ckeditor.com/docs/ckeditor5/latest/features/html/general-html-su..., something like:

    config:
      htmlSupport:
        allow:
           -
            name: 'br'
            attributes: true

But no results yet ! :(

#4 thanks for the solution, i've seen your MR, but error still appeared in my case
I found the solution from this https://php.watch/versions/8.2/dynamic-properties-deprecated#AllowDynami....
It's work for me !

ducviethaboo → created an issue.

It's work perfect now ! :D

I see there is a new declaration for routing "user.login" in mail_login.routing.yml, but there is no controller or somthing handler for this routing to overwrite the core routing. So can someone explain to me what adding routing and new form MailLoginUserLoginForm is for?

ducviethaboo → created an issue.

With multilingual site. Validate the form with $submit_button['#value']->render() == 'Save permissions' is not working because in another language, we will have another value for button. So I think it's better if give the submit button a value that we can detect when click this button, and validate the form with this value, somthing like that:
alter form:
$form["actions"]["submit"]['#saved_permission'] = TRUE;
and validate function will be:

$submit_button = $form_state->getTriggeringElement();
  // no need to run this validation when submitting filter changes.
  if (isset($submit_button['#saved_permission'])) {