🇬🇧United Kingdom @williamsona

Sorry, I am working on trying to apply 2 patches and getting muddled up on the issue number. Please ignore all the other patches.

I'm not sure why you need to show a duration label with no dropdown select. This patch just hides the parent element on an existing node.

I'm not sure why but these patches don't apply as expected.

This patch fixes my issue. I have tested this with more than 1 allowed value and it also works as expected.

I am on v4.1.6
Initially it looks like the field is hidden on a new node but if you edit an existing node then a label pops up with no drop down.
See screenshots.
I think the js needs hideLabels(wrapper); somewhere to hide this? But I'm not sure where it would go.
My set up is:
Allowed duration values = custom
Default duration = 0
Smart date and time range
Provide a checkbox to make it an all day event.

smustgrave → credited williamsona → .

Screenshot to show the error message restricted to the end value after the code change.

williamsona → created an issue.

williamsona → created an issue.

This is what I get when I try to create a new branch.
If I navigate into the current fork then I have no 2.0.x in the dropdown.

Sorry, this is the 1st time I have ever contributed so I'm probably making lots of mistakes!

I think so, comment #16 says book is moving away from core?
Should I still be forking core?

I can't access the 2.0.x branch. I have tried creating a new branch from this page but 2.0.x is not an option.

I then tried to pull the code and make the change. Upon pushing I am getting this message fatal: unable to access 'https://git.drupalcode.org/project/book.git/': The requested URL returned error: 403

williamsona → changed the visibility of the branch 1.0.x to hidden.

No, I have just tested this again having upgraded to drupal core 10.3.1 and the problem still exists.

Follow the steps above:

• Create a top level book page and 2 child book pages.
• Navigate to /admin/structure/book
• Find Top level book
• Edit order and titles
• Have an empty title field
• Save book

See screenshots.

This takes the user to a WSOD.

Sorry, ignore #57. I found a setting called "Use group role" in the slick settings and checking this fixed my problem.

Morning, I am using
Accessible slick library 1.0.1
Slick library 1.8.0
Slick 3.0.3
Slick views 3.0.2
Blazy 3.0.10
Core 10.3.1

These are all upgrades for a slider I have had on my site for 2 years.

I have a content type Feature which a user adds content to then I have an entityqueue that is used to order the slides. this is all output in a slick view.

I have selected the accessible slick library and initially everything looks good with my custom optionset. But if I try and make a change to my custom optionset or just save the slick settings page with no changes then my slider breaks.

In the view settings I change the default optionset to Default then the slider works again (even after a save of slick settings)
For my current set up this works fine as I can override defaults in the view settings.

I am currently trying to find out why the view doesn't work with a custom optionset using the accessible slick library but haven't come up with a solution yet.

Just incase this helps anyone or I am missing some steps?

williamsona → made their first commit to this issue’s fork.

Hi, thanks.

I have created a MR for the book module also.

@cilefen I have created a merge request.

A user is able to change the title of a node using the book admin edit page. So they are essentially saving a node with no title, it seems to bypass the required title status of the node edit form. This is the error that is produced.
Drupal\Core\Entity\EntityStorageException: SQLSTATE[23000]: Integrity constraint violation: 1048 Column 'title' cannot be null: INSERT INTO "node_field_data" ("nid", "vid", "type", "langcode", "status", "uid", "title", "created", "changed", "promote", "sticky", "default_langcode", "revision_translation_affected") VALUES (:db_insert_placeholder_0, :db_insert_placeholder_1, :db_insert_placeholder_2, :db_insert_placeholder_3, :db_insert_placeholder_4, :db_insert_placeholder_5, :db_insert_placeholder_6, :db_insert_placeholder_7, :db_insert_placeholder_8, :db_insert_placeholder_9, :db_insert_placeholder_10, :db_insert_placeholder_11, :db_insert_placeholder_12); Array ( [:db_insert_placeholder_0] => 83 [:db_insert_placeholder_1] => 1357 [:db_insert_placeholder_2] => basic_page [:db_insert_placeholder_3] => und [:db_insert_placeholder_4] => 1 [:db_insert_placeholder_5] => 0 [:db_insert_placeholder_6] => [:db_insert_placeholder_7] => 1479117403 [:db_insert_placeholder_8] => 1715849224 [:db_insert_placeholder_9] => 0 [:db_insert_placeholder_10] => 0 [:db_insert_placeholder_11] => 1 [:db_insert_placeholder_12] => 1 ) in Drupal\Core\Entity\Sql\SqlContentEntityStorage->save() (line 817 of /app/web/core/lib/Drupal/Core/Entity/Sql/SqlContentEntityStorage.php).

williamsona → created an issue.