twiesing → made their first commit to this issue’s fork.
twiesing → made their first commit to this issue’s fork.
twiesing → changed the visibility of the branch 8.x-4.x to hidden.
twiesing → changed the visibility of the branch 3548896-phpstan-6-rest to hidden.
Is there any estimate on how long it takes from a GitHub PR until the code appears in a release?
The following services.yml files exist:
-
./legacy/wisski_apus/wisski_apus.services.yml
-
./legacy/wisski_pipe/wisski_pipe.services.yml
-
./wisski_adapters/dms/wisski_adapter_dms.services.yml
-
./wisski_adapters/geonames/wisski_adapter_geonames.services.yml
-
./wisski_adapters/getty/wisski_adapter_aat.services.yml
-
./wisski_adapters/getty_new/wisski_adapter_getty_new.services.yml
-
./wisski_adapters/gnd/wisski_adapter_gnd.services.yml
-
./wisski_adapters/gnd_new/wisski_adapter_gnd_new.services.yml
-
./wisski_adapters/zotero/wisski_adapter_zotero.services.yml
-
./wisski_api/wisski_api.services.yml
-
./wisski_autocomplete/wisski_autocomplete.services.yml
-
./wisski_core/wisski_core.services.yml
-
./wisski_data/wisski_authfile/wisski_authfile.services.yml
-
./wisski_doi/wisski_doi.services.yml
-
./wisski_iip_image/wisski_iip_image.services.yml
-
./wisski_pathbuilder/wisski_pathbuilder.services.yml
-
./wisski_salz/wisski_salz.services.yml
-
./wisski_statistics/wisski_statistics.services.yml
twiesing → made their first commit to this issue’s fork.
Done: https://github.com/pfrenssen/coder/pull/269
Should I close the MR on GitLab?
I've created a merge request to relax the check based on the above.
In the MR I decided to allow doc comments that start with a doc tag (preceding whitespace is fine).
To illustrate, I've also added a couple of test cases:
function test3() {
/** I am not allowed. */
something();
/**
* I am also not allowed.
* Even though I go on multiple lines.
*/
something();
/** @some-unknown-tag I am allowed. */
something();
/**
*
* @some-tag-on-the-third-line */
something();
/**
* @some-tag-here
*
* Additonal text after is fine.
*/
something();
/**
* There is some text here before the doc tag.
*
* This should not be allowed.
*
* @some-other-tag
*/
something();
}twiesing → made their first commit to this issue’s fork.
I believe I did catch all the cases where a "use DependencySerializationTrait" was needed.
Going to mark as fixed now, if there's a case I missed please reopen.
twiesing → made their first commit to this issue’s fork.
twiesing → made their first commit to this issue’s fork.
twiesing → changed the visibility of the branch 3547823-phpstan-5 to active.
twiesing → changed the visibility of the branch 3547823-phpstan-5 to hidden.
I've created a merge request that should address all of the issues from above.
This was fixed by Kai a while back, so marking the issue as fixed and re-assigning.