Account created on 25 May 2020, almost 5 years ago
#

Merge Requests

Recent comments

🇨🇴Colombia diarcastro

The code is already there. I added some comments to clarify that part and added an extra parameter to avoid a caching issue.

What do you think @chrisscrumping @e0ipso ?

https://git.drupalcode.org/project/storybook/-/merge_requests/19/diffs?c...

🇨🇴Colombia diarcastro

@Anybody (#33) having that the loadjs script is loaded in the global scope we don't need to use `window.loadjs = ...` because `var loadjs = ...` will be in the same scope and `window.loadjs === loadjs`, so we don't need to define the variable directly in the window object.

And you are right that's fix should be done in the LoadJS Library instead.

I made a quick example here https://codepen.io/diarcastro/pen/BaqQwxg

🇨🇴Colombia diarcastro

I think the problem is because the variable is not defined and if we run JS in a strict mode that error jumps.
I just created a simple patch to fix the issue and the fix is only defining the variable.
It worked for me on Drupal 9.5.x.

Production build 0.71.5 2024