πŸ‡ΊπŸ‡ΈUnited States @csmdgl

Account created on 13 November 2019, about 5 years ago
#

Merge Requests

Recent comments

πŸ‡ΊπŸ‡ΈUnited States csmdgl

This is not a new bug and has long existed without causing problems for us. It has become apparent by moving to PHP 8.

When enabling a module via drush, this warning is produced:
Undefined array key "php" environment.inc:790 [warning]

By itself, we were tolerating and ignoring the bug. But when enabling a module via the UI, this produces thirteen pages of warnings of these two types:
Warning: Undefined array key "php" in _system_modules_build_row() (line 1027 of /var/www/html/docroot/modules/system/system.admin.inc).
and
Deprecated function: version_compare(): Passing null to parameter #2 ($version2) of type string is deprecated in _system_modules_build_row() (line 1027 of /var/www/awards.practicegreenhealth.org/pgh-awards/docroot/modules/system/system.admin.inc).

Features is corrupting the system module cache with this line in features_get_info():
unset($row->info['php']);

Patch attached.

πŸ‡ΊπŸ‡ΈUnited States csmdgl

I also have this problem. I believe it has something to do with the features module clearing info['php']. It seems like the ctools and context modules are also involved, but I haven't completely tracked it down yet.

πŸ‡ΊπŸ‡ΈUnited States csmdgl

New patch for 3.0.0-beta1 for the paging issue.

πŸ‡ΊπŸ‡ΈUnited States csmdgl

Rerolled #67 for 10.2.5.
Patch attached this time.

πŸ‡ΊπŸ‡ΈUnited States csmdgl

In D7, there is a bug in the logic of views_data_export_garbage_collect(). It is calling views_data_export_view_clear() with an array of eids, but views_data_export_view_clear() only works for an individual eid.

Patch attached.

πŸ‡ΊπŸ‡ΈUnited States csmdgl

Version of the patch for PHP 7

πŸ‡ΊπŸ‡ΈUnited States csmdgl

Step #2 of views_data_export_garbage_collect() function should indeed take care of deleting the temporary files. However, in cases where that delete fails for whatever reason, the file_usage entry is not removed from the database, but the views_data_export entry is. The file_delete() only removes the file_usage if the actual file delete was successful, even when the force parameter is true. The attached patch explicitly removes the file_usage before doing the delete. This will allow system_cron to attempt to delete the stuck expired temporary file without logging an error that it is in use by views_data_export. Additionally, make sure that views_data_export_cron runs prior to system_cron so this garbage collect happens before system_cron.

πŸ‡ΊπŸ‡ΈUnited States csmdgl

Attaching patch. The problem is due to a backward breaking change in call_user_func_array(). Specifically this change: β€œIt is a fatal error to have a numeric key in args appear after a string key, or to have a string key that does not match the name of any parameter of callback.”

This patch only does not include the entire js data from $_REQUEST in the arguments array if the php version is >= 8.

πŸ‡ΊπŸ‡ΈUnited States csmdgl

csmdgl β†’ created an issue.

πŸ‡ΊπŸ‡ΈUnited States csmdgl

Re-rolling #23 for 2.0.0-beta3

πŸ‡ΊπŸ‡ΈUnited States csmdgl

Test patch in 21 for 2.x-dev

πŸ‡ΊπŸ‡ΈUnited States csmdgl

Reroll patch in 17.

Production build 0.71.5 2024