I kinda jumped the gun here, the patch is ok but I guess we need a proper MR for merging. I'll roll it later this week if no one does until then.
Tested today, works on a clean install & ran "test-only changes" job, which shows coverage. Everything looks fine by me !
I'll change it to RTBC shortly if no one else does in the meantime.
Ok, so, after much contemplation and reading the docs, it seems the Test-only changes job is supposed to fail ? I feel a little silly tbh, but hey, I learnt something new !
Changing the status to need review.
Weirdly enough, tests succeed on a ddev install with ddev/ddev-selenium-standalone-chrome
for functionalJS tests.
I'll have a deeper look later this week, maybe there is some configuration discrepancies on my env vs drupal-ci.
Hi,
I just pushed a commit in mr !8316 fixing this error.
First time contributing to the core, so please let me know if I didn't apply proper workflow, naming or anything else.