🇪🇸Spain @SadySierralta

Thank you!

sadysierralta → created an issue.

sadysierralta → made their first commit to this issue’s fork.

I tested it, and it doesn’t seem to work well when using Media Responsive Thumbnail (on rendered entity) or PhotoSwipe. We should also consider that one formatter can use multiple image styles, e.g.:

photoswipe_thumbnail_style: 21_9
photoswipe_image_style: 16_9

The same applies to Blazy.

Part of the issue might be that we are limiting this only to fields of type "image" and only considering settings that contain the word "image" in their string.

Additionally, the code has room for improvement.

@antonio.nunez can you check if necessary dependencies are being added for the added task? Also just made a review for the MR, check please.

@antonio.nunez i've added some reviews in MR, check it when possible.

Also i have a request, would you mind adding a link to the webform? I think it would be great in case someone wants to check the whole configuration, speeds up the process to go there.

Thank you beforehand

Everything works great! I just have one suggestion—could you review a change I'd like to make in the code?

There is something we still need to do, in the revisions reports page, for paragraphs, we need to add a column with the host entity link, i will take care of it

sadysierralta → created an issue.

Tested and works great, only some typos where found in MR.

sadysierralta → created an issue.

sadysierralta → created an issue.

sadysierralta → made their first commit to this issue’s fork.

Rerolled patch from #39 for 10.3.x

Mr looks great to me.

Added some coments to mr, take a look please.

Added some coments to mr, take a look please.

Mr looks great to me

Mr looks great to me

MR looks great!

Tested It and it works great

Mr looks great to me! nice job

SadySierralta → created an issue.

SadySierralta → changed the visibility of the branch 3465167-custom-contrib-separately to active.

SadySierralta → changed the visibility of the branch 3465167-custom-contrib-separately to hidden.

SadySierralta → created an issue.

Stripe does not allow more than one subscription at time, implement a way to avoid it in drupal.

We should probably use checkout.session.completed instead of payment_intent.succeded to keep the context.

Changed the exit solution, wich is kinda brute, in favuor of Throwing a NeedsRedirectException

This is still happening...

Using code from https://www.drupal.org/project/commerce_stripe_checkout/issues/3439876 🐛 When bigpipe enabled a RuntimeException occurs in payment step Needs review and https://www.drupal.org/project/commerce_stripe_checkout/issues/3436134 🐛 Error: Call to a member function get() on null en Drupal\commerce_stripe_checkout\Plugin\Commerce\PaymentGateway\CommerceStripeCheckoutCheckout Needs review

SadySierralta → changed the visibility of the branch 3439876-use-onreturn to active.

SadySierralta → changed the visibility of the branch 3439876-use-onreturn to hidden.

SadySierralta → created an issue.

PDF was missing from commerce invoice confirmation mail attachments, after applying #5 the error, "Symfony\Component\HttpFoundation\Exception\SessionNotFoundException: Session has not been set.", is no longer appearing and PDF is attached in mail.

By the way this was happening while cron context.

Using code from https://www.drupal.org/project/commerce_stripe_checkout/issues/3438907 📌 Allow developers to alter or add params before stripe session creation Needs review and https://www.drupal.org/project/commerce_stripe_checkout/issues/3438821 📌 Allow payment completion via webhook Needs review

SadySierralta → changed the visibility of the branch 3436233-allow-passing-subscription-data to hidden.

Moving code to a submodule.

SadySierralta → created an issue.

Reloading the order again and checking in paymentSuccess if the order is complete (completed by commerce payment updater after saving payment in the onNotify) before saving seems to be working, not the best approach but i think it is ok.

The code might lead to an order missmatch exception, checking if possible to make a solution.

SadySierralta → created an issue.

I credited https://www.drupal.org/u/crzdev → , he took part on the solution.

MR looks great to me.