Account created on 18 March 2019, about 6 years ago
#

Merge Requests

More

Recent comments

🇪🇸Spain SadySierralta

I tested it, and it doesn’t seem to work well when using Media Responsive Thumbnail (on rendered entity) or PhotoSwipe. We should also consider that one formatter can use multiple image styles, e.g.:

photoswipe_thumbnail_style: 21_9
photoswipe_image_style: 16_9

The same applies to Blazy.

Part of the issue might be that we are limiting this only to fields of type "image" and only considering settings that contain the word "image" in their string.

Additionally, the code has room for improvement.

🇪🇸Spain SadySierralta

@antonio.nunez can you check if necessary dependencies are being added for the added task? Also just made a review for the MR, check please.

🇪🇸Spain SadySierralta

@antonio.nunez i've added some reviews in MR, check it when possible.

Also i have a request, would you mind adding a link to the webform? I think it would be great in case someone wants to check the whole configuration, speeds up the process to go there.

Thank you beforehand

🇪🇸Spain SadySierralta

Everything works great! I just have one suggestion—could you review a change I'd like to make in the code?

🇪🇸Spain SadySierralta

There is something we still need to do, in the revisions reports page, for paragraphs, we need to add a column with the host entity link, i will take care of it

🇪🇸Spain SadySierralta

Tested and works great, only some typos where found in MR.

🇪🇸Spain SadySierralta

Rerolled patch from #39 for 10.3.x

🇪🇸Spain SadySierralta

Added some coments to mr, take a look please.

🇪🇸Spain SadySierralta

Added some coments to mr, take a look please.

🇪🇸Spain SadySierralta

Mr looks great to me

🇪🇸Spain SadySierralta

SadySierralta changed the visibility of the branch 3465167-custom-contrib-separately to active.

🇪🇸Spain SadySierralta

SadySierralta changed the visibility of the branch 3465167-custom-contrib-separately to hidden.

🇪🇸Spain SadySierralta

Stripe does not allow more than one subscription at time, implement a way to avoid it in drupal.

🇪🇸Spain SadySierralta

We should probably use checkout.session.completed instead of payment_intent.succeded to keep the context.

🇪🇸Spain SadySierralta

Changed the exit solution, wich is kinda brute, in favuor of Throwing a NeedsRedirectException

🇪🇸Spain SadySierralta

Using code from https://www.drupal.org/project/commerce_stripe_checkout/issues/3439876 🐛 When bigpipe enabled a RuntimeException occurs in payment step Needs review and https://www.drupal.org/project/commerce_stripe_checkout/issues/3436134 🐛 Error: Call to a member function get() on null en Drupal\commerce_stripe_checkout\Plugin\Commerce\PaymentGateway\CommerceStripeCheckoutCheckout Needs review

🇪🇸Spain SadySierralta

PDF was missing from commerce invoice confirmation mail attachments, after applying #5 the error, "Symfony\Component\HttpFoundation\Exception\SessionNotFoundException: Session has not been set.", is no longer appearing and PDF is attached in mail.

By the way this was happening while cron context.

🇪🇸Spain SadySierralta

Using code from https://www.drupal.org/project/commerce_stripe_checkout/issues/3438907 📌 Allow developers to alter or add params before stripe session creation Needs review and https://www.drupal.org/project/commerce_stripe_checkout/issues/3438821 📌 Allow payment completion via webhook Needs review

🇪🇸Spain SadySierralta

SadySierralta changed the visibility of the branch 3436233-allow-passing-subscription-data to hidden.

🇪🇸Spain SadySierralta

Reloading the order again and checking in paymentSuccess if the order is complete (completed by commerce payment updater after saving payment in the onNotify) before saving seems to be working, not the best approach but i think it is ok.

🇪🇸Spain SadySierralta

The code might lead to an order missmatch exception, checking if possible to make a solution.

Production build 0.71.5 2024