- Issue created by @omarlopesino
- Merge request !66Issue #3509570: Prevent error on sites without paragraphs → (Merged) created by omarlopesino
- 🇪🇸Spain omarlopesino
The MR solves the problem for me, please consider reviewing and merging, thanks!
- 🇪🇸Spain lpeidro Madrid
Hello Omar:
Thank you very much for your contribution. However, the most appropriate way to fix this issue is to prevent the insight logic from running when the Paragraphs module is not enabled.
I believe it would be better to ask the plugins if they have any dependencies that are not available.
There is already some logic for this in the task plugins, but the result is not currently propagated to the insights.
- 🇪🇸Spain omarlopesino
I agree that would be a definitive solution. In the meanwhile, a patch generated from this MR can be used to be able to view status report in sites using xray audit but not using paragraphs.
- 🇪🇸Spain lpeidro Madrid
Taking advantage of this specific issue for the Paragraph case, we have implemented functionality to manage the dependency between insights and their plugin tasks.
The dependency on the modules is set in the Task Plugin definition. If the dependency is broken, the Task Plugin will be disabled. Similarly, in the insight, if the Task Plugin is inactive due to dependency issues, the corresponding insight will not be executed under any circumstances.
It is ready for testing.
-
lpeidro →
committed 9e8dc34a on 1.x authored by
omarlopesino →
Issue #3509570: Prevent error on sites without paragraphs
-
lpeidro →
committed 9e8dc34a on 1.x authored by
omarlopesino →
Automatically closed - issue fixed for 2 weeks with no activity.