Account created on 17 February 2019, almost 6 years ago
#

Merge Requests

Recent comments

🇧🇾Belarus maksim_matuzka

Hi everyone!
@mtoscano, I think the root cause is incorrect array of bundles, if you debug this function _comment_notify_get_comment_enabled_bundles() you will see that only one bundle per entity type can be returned. That is why user can't see the checkbox after the new bundle was created. You can test patch https://www.drupal.org/project/comment_notify/issues/3488180#comment-158... 🐛 Enabled bundles: incorrect array from _comment_notify_get_comment_enabled_bundles() Needs work
Thanks!

🇧🇾Belarus maksim_matuzka

Hi @web-beest, I think you are using two different ways in one solution) If you have '@yoast_seo.field_manager' as an argument in services.yml, you don't need to add create() method.

🇧🇾Belarus maksim_matuzka

Added recommendation (best practice) for performance regarding caching

🇧🇾Belarus maksim_matuzka

I got confused a few times because we have a standard regarding 80 characters per line, but it doesn't apply for "if" conditions. So if we accept option A, then we kill two birds with one stone: readability and minus the exception to the general rule. My vote for "multiple lines".

Production build 0.71.5 2024