siegrist → made their first commit to this issue’s fork.
siegrist → created an issue.
siegrist → made their first commit to this issue’s fork.
I am not sure in what entities may have used commerce\\BundleFieldDefinition. We might be able to filter by commerce, but it's then unclear that we find all occurrences in contrib and custom code.
In this original issue, we did not implement a hook to replace the already installed storage configs.
https://www.drupal.org/project/commerce/issues/2922811 →
With this very low-level update hook, we can change the used BundleFieldDefinition as the commerce and entity versions have the same footprint.
This way we don't need to implement it on the 2.x branch but can do it simply on the 3.x branch.
/**
* Update outdataed payment method cache for commerce 3.
*/
function hook_update_xxxx() {
$old_string = 'O:37:"Drupal\\commerce\\BundleFieldDefinition":5:';
$new_string = 'O:35:"Drupal\\entity\\BundleFieldDefinition":5:';
$escaped_old_string = \Drupal::database()->escapeLike($old_string);
$escaped_new_string = \Drupal::database()->escapeLike($new_string);
\Drupal::database()
->query(
"UPDATE {key_value}
SET value = REPLACE(value, '" . $escaped_old_string . "', '" . $escaped_new_string . "')"
)->execute();
}
https://www.drupal.org/project/commerce/issues/3150917 →
This was the issue where this change was introduced, and therefore it makes sense to have a min requirement for commerce versions above this version. https://www.drupal.org/project/commerce/releases/8.x-2.25 →
^2.25 || ^3
siegrist → created an issue.
We have the same issue. Is there a consistent fix for this?
What is holding this up?
siegrist → made their first commit to this issue’s fork.
siegrist → made their first commit to this issue’s fork.
siegrist → made their first commit to this issue’s fork.
This was never committed. We have been using it for years, and it works great. Please commit the fix.
Done.
siegrist → created an issue.
siegrist → created an issue.
Siegrist → changed the visibility of the branch 3452717-cache-menu-links to active.
Siegrist → changed the visibility of the branch 3452717-cache-menu-links to hidden.
Siegrist → created an issue.
Siegrist → changed the visibility of the branch 3449445-revision-creation-time to hidden.
Siegrist → created an issue.
This patch works for us. Thanks
Siegrist → created an issue.
I hope I haven't deleted any functionality. Would be nice to get this committed. Thanks
Ok, this solution passes the test. Removing the unused code.
Siegrist → created an issue.
Siegrist → changed the visibility of the branch 3426428-use-request-directly to hidden.
Siegrist → created an issue.
Re-role for 10.2.3
Siegrist → made their first commit to this issue’s fork.
Siegrist → made their first commit to this issue’s fork.
EntityQueryExtension needs this call wrapped in a render context.
return $connection->items($context);
Siegrist → created an issue.