SQL error

I recently experienced this when upgrading to D11 / Commerce 3 on a project... Unfortunately I can't remember how I fixed this... I think one of the update hooks was problematic.
I think I also tried uninstalling the page_cache module / big pipe.

It appears related to a database table modification for an entity id

See for example https://www.drupal.org/project/group/issues/3381083 💬 Errors upgrading from 1.5 -> 2.1 (with config entities) Active

Perhaps it won't happen on a fresh install of version 3 but hacking tables is beyond me, a database update to the install file or sql patch is needed it appears

We have the same issue. Is there a consistent fix for this?

To sum up our findings with @siegrist:

Since this commit commerce's BundleFieldDefinition got deprecated in favor of the implementation of the entity module. This happened 7 years ago.

The issue is that the sites that existed before the deprecation might still have commerce's BundleFieldDefinition serialized in their field storage definition. See e.g. select * from key_value where collection='entity.definitions.installed' and name='commerce_payment_method.entity_type'; So when updating to DC 3.x these definitions start referring to a nonexistent class.

This affects pretty much all payment method types, profile types and product types as well.

@jsacksick Would it make sense for you to have an update hook in commerce core 2.x that updates these field storage definitions to use the entity module implementation instead? (Once you update to 3.x it's too late.) I haven't tried but just saving the entity type might recreate the field storage definitions as well.

In this original issue, we did not implement a hook to replace the already installed storage configs.

https://www.drupal.org/project/commerce/issues/2922811 →

With this very low-level update hook, we can change the used BundleFieldDefinition as the commerce and entity versions have the same footprint.
This way we don't need to implement it on the 2.x branch but can do it simply on the 3.x branch.

/**
 * Update outdataed payment method cache for commerce 3.
 */
function hook_update_xxxx() {
  $old_string = 'O:37:"Drupal\\commerce\\BundleFieldDefinition":5:';
  $new_string = 'O:35:"Drupal\\entity\\BundleFieldDefinition":5:';

  $escaped_old_string = \Drupal::database()->escapeLike($old_string);
  $escaped_new_string = \Drupal::database()->escapeLike($new_string);

  \Drupal::database()
    ->query(
      "UPDATE {key_value}
     SET value = REPLACE(value, '" . $escaped_old_string . "', '" . $escaped_new_string . "')"
    )->execute();
}

hm... This update hook looks a bit risky, isn't there a way to condition the update. There is no "name" we can filter on?

I am not sure in what entities may have used commerce\\BundleFieldDefinition. We might be able to filter by commerce, but it's then unclear that we find all occurrences in contrib and custom code.

We could definitely add something like WHERE collection='entity.definitions.installed' AND name LIKE %.field_storage_definitions'.

My bigger concern is if this is too database specific or not. We might want to do a SELECT, do the replacement in php and do a separate UPDATE instead.