Errors upgrading from 1.5 -> 2.1 (with config entities)

Hi there

I have a problem very similar to this and also use the groups module in a complex build. Did you get any pointers on what this error might be and how to fix it. I'm real stumped right now!

Thanks

Sam

I'm pretty sure this is due to an entry in the key_value table that should have been deleted.

Try executing SELECT * FROM key_value WHERE name='group_content.field_storage_definitions'; and see if it returns any records. If it does, you should manually remove that row. (test it first in a development environment to be extra careful.

For me the problem is in the key_value in the collection named: "file.field_storage_definitions" -- because of the use of Group Taxonomy (in one case, even where it was no longer enabled). Group taxonomy added storage definitions for entity_id and entity_id_str but they are done using a class that is of the right instance for Drupal10's purposes.

I'm still at a loss at how to fix it right now. There has been some work around it, but the patch does not seem to be working from me.
https://www.drupal.org/project/group_taxonomy/issues/3331610 📌 Support Group 2.x Needs review

Sam or safety_pin did you ever find your way around it?
Deleting the keyvalue did not work for me. Nor did deleting the specific items within the value. Not really a viable approach for production in any case.

Could any of you please answer the questions in:

Please read this carefully before posting

I am missing steps to reproduce on a clean install, whether you used any invasive patches, ...

@kristiaanvandeneynde - I doubt very much that this issue could be replicated with a clean install; in the original description I stated that I had used several patches from ✨ Entities identified by strings as group content Closed: won't fix . I guess I can't speak for the others who have commented here, but I personally don't have any expectation of support from you for this issue because I used those patches. I'm really grateful for the work you've done to maintain and improve this module. I think we're still missing support for core config entities (menus), from what I've read about your work to support that, there's a lot of core mess that will need to be cleaned up before that's possible. But, I'm thankfully in a situation where it's not strictly necessary for our groups to have access to the menu system.

@adriancotter - If I remember correctly, I resolved this issue using some sql in a custom module to move some data around from the "support config entities" patch:

function custom_module_fix_group_db_install() {
  $database = \Drupal::database();

  // We need to re-add the entity_id column to group_content_field_data.
  // Get data from the table that the patch added ('group_content__entity_id').
  $database->query("ALTER TABLE group_content_field_data ADD entity_id INT(11);");
  $database->query("
    UPDATE group_content_field_data
    JOIN group_content__entity_id ON group_content_field_data.id = group_content__entity_id.entity_id
    SET group_content_field_data.entity_id = group_content__entity_id.entity_id_target_id;
  ");

  // Now, we can remove all the messed up config, from the old field.
  $database->query("DELETE FROM key_value WHERE name='group_content.field_schema_data.entity_id_str';");
  $database->query("DROP TABLE group_content__entity_id_str;");
  $database->query("DELETE FROM key_value WHERE name='group_content.field_storage_definitions';");
}

I was using Group Taxonomy and the string id patch (#2797793) which has been my main source of issues. I also had group_menu and a custom module. So I am not sure I can give an easy answer to reproducing.

I have walked a lot of that back with this patch on group taxonomy below and have things mostly working (the remaining issues I think are mostly about additional customization of my own around group taxonomy and paragraphs, and other modules like quick node clone, etc). I was able to update the site most importantly.
https://www.drupal.org/project/group_taxonomy/issues/3331610 📌 Support Group 2.x Needs review

@safetypin Okay thanks for the clarification, I was seeing a few similar issues like these and none of them had any clear information for me to work with. But if the goal is for those in the same boat to be able to help each other out, then I'm fully onboard with keeping this issue open.

i am on the same boat as @safetypin , however have been unable to fix with that solution, still working to see i can make it , but in the mean time if someone have a patch or a clear solution would be nice to hear

Same problem when going from 1.6 to 2.2.2

I had the same issue when upgrading from 1.x to 2.2.2.

Note that the site only used this patch menus, so you might need to tweaks som stuff.
And as always, try this on a dev environment first.

It was solved with the following steps:

1. First run the function below to:
   1. Create a temporary table to store the menus (group content), (only content need to recreate them is stored).
   2. Temporarily store the menus (group content) in a new table
   3. Remove the menus (group content).
   4. Undo what the patch created (thanks to @safetypin)

   function custom_module_pre_upgrade() {
     $database = \Drupal::database();
   
     // Create temporary table for group_content__entity_id_str.
     $database->query("CREATE TABLE temporary_group_menu (
       group_id int(11) UNSIGNED NOT NULL,
       group_content_id int(11) UNSIGNED NOT NULL,
       menu_id_str varchar(255) NOT NULL
     )");
   
     // Copy data from group_content__entity_id_str to temporary_group_menu.
     $database->query("
       INSERT INTO temporary_group_menu (group_id, group_content_id, menu_id_str)
       SELECT gcfd.gid, gceis.entity_id, gceis.entity_id_str_target_id
       FROM group_content__entity_id_str AS gceis
       JOIN group_content_field_data AS gcfd ON gceis.entity_id = gcfd.id
     ");
   
     // Delete all group content from temporary_group_menu.
     $result = $database->query("
       SELECT group_content_id FROM temporary_group_menu
     ");
     foreach ($result as $row) {
       $group_content_id = $row->group_content_id;
       $group_content = \Drupal\group\Entity\GroupContent::load($group_content_id);
       $group_content->delete();
     }
   
     // We need to re-add the entity_id column to group_content_field_data.
     // Get data from the table that the patch added ('group_content__entity_id').
     $database->query("ALTER TABLE group_content_field_data ADD entity_id INT(11);");
     $database->query("
       UPDATE group_content_field_data
       JOIN group_content__entity_id ON group_content_field_data.id = group_content__entity_id.entity_id
       SET group_content_field_data.entity_id = group_content__entity_id.entity_id_target_id;
     ");
   
     // Now, we can remove all the messed up config, from the old field.
     $database->query("DELETE FROM key_value WHERE name='group_content.field_schema_data.entity_id';");
     $database->query("DELETE FROM key_value WHERE name='group_content.field_schema_data.entity_id_str';");
     $database->query("DROP TABLE group_content__entity_id;");
     $database->query("DROP TABLE group_content__entity_id_str;");
     $database->query("DELETE FROM key_value WHERE name='group_content.field_storage_definitions';");
   }
   

2. Remove the patch and update group to version 2.x (2.2.2 in my case)
3. Run the function below to:
   1. Recreate the menus (as group relationships)
   2. Remove the temporary table

   function custom_module_post_upgrade() {
     $database = \Drupal::database();
   
     // Recreate group menus.
     $result = $database->query("SELECT group_id, menu_id_str FROM temporary_group_menu");
     foreach ($result as $row) {
       $gid = $row->group_id;
       $menu_id = $row->menu_id_str;
       $group = \Drupal::entityTypeManager()->getStorage('group')->load($gid);
       $menu = \Drupal::entityTypeManager()->getStorage('menu')->load($menu_id);
   
       if (!$group || !$menu) {
         continue;
       }
   
       $group->addRelationship($menu, 'group_menu:menu');
     }
   
     // Delete table since we don't need it anymore.
     $database->query("DROP TABLE temporary_group_menu;");
   }