Contrib.social

Support Group 2.x

Open on Drupal.org →
Created on 6 January 2023, almost 2 years ago
Updated 9 May 2023, over 1 year ago

Problem/Motivation

Needs to update to Group 2.x to support Drupal 10 - eventually to support GRoup 3.x

Steps to reproduce

note that the 8.x-1.x module doesn't work with Group 2.x

Proposed resolution

undo the changes made by Group module patch ✨ Entities identified by strings as group content Closed: won't fix

Remaining tasks

  • Test with users without site admin privileges
  • either update \Drupal\group_taxonomy\GroupTaxonomyService and Drupal\group_taxonomy\VocabularyListBuilderBase or remove them if they are no longer needed.

    • User interface changes

    minimal

    API changes

    minimal

    Data model changes

    use the group_config_wrapper to do the relationship to vocabularies using a string name as vocabularies are config entities

📌 Task
Status

Needs review

Version

1.0

Component

Code

Created by

🇺🇸United States jrglasgow Idaho

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

  • Merge request !5Issue #3331610: Support Group 2.x → (Open) created by jrglasgow
  • Comment over 1 year ago →
    🇺🇸United States jrglasgow Idaho

    I have been working with this patch in production since March. This morning I found a bug where on the Taxonomy Vocalubary Overview page ( /admin/structure/taxonomy/manage/{taxonomy_vocabulary}/overview ) the expected Local Action Link "Add term" wasn't appearing on the page... in my investigations I saw that in GroupTaxonomyVocabularyRouteProvider we were pointing entity.taxonomy_vocabulary.canonical to entity.taxonomy_vocabulary.overview_form, which means that the Router, when doing a route match to see if there are any action links for the block, gets entity.taxonomy_vocabulary.canonical instead of entity.taxonomy_vocabulary.overview_form. I added entity.taxonomy_vocabulary.canonical to the list of routes for the action link to appear on.

    updated patch attached

  • Comment 11 months ago →
    🇺🇸United States adriancotter

    Hey jrglasgow thanks for the work on this.
    If I am reading the thread correctly... if one is updating to Drupal 10
    one needs to use this patch 3331610-9-support-group-2.x.patch (or an earlier one?)

    And then once updated, remove that patch and use group_taxonomy-3232198-10.patch?

    I am running into the TypeError: Drupal\Core\Entity\Sql\DefaultTableMapping error that you mention in #6, but struggling to get around it...

    Thanks for any advice!

  • Comment 10 months ago →
    🇺🇸United States electrokate

    Confirming that the patch 3331610-7-group-src-Field-GroupContentReferenceDefinition.patch fixes this error

    The script tried to call a method on an incomplete object. Please ensure that the class definition "Drupal\group\Field\GroupContentReferenceDefinition" of the object you are trying to operate on was loaded _before_ unserialize() gets called or provide an autoloader to load the class definition in field_purge_batch() (line 81 of core/modules/field/field.purge.inc)

    that arises on a cron run after upgrading to group 2.0

    Thank you very much!

  • First commit to issue fork.
  • Comment 29 days ago →
    🇳🇱Netherlands arantxio Dordrecht

    I am currently upgrading one of our sites to Group 2, and we kept seeing this warning.

    Deprecated: Creation of dynamic property Drupal\group_taxonomy\GroupTaxonomyService::$db is deprecated in /var/www/html/web/modules/contrib/group_taxonomy/src/GroupTaxonomyService.php on line 82

    The changes pushed should fix the error.

    So far most of the stuff seems to be working that has to do with the patch. I will keep working on code on our side and if all goes well I'll leave feedback on this issue.

contrib.social Blog FAQ Discussions
Production build 0.71.5 2024