ethangeorgi → created an issue.
The dev version works for me. The site I'm testing with loads now, without errors. It was not using new "season" fields.
I can see the new code from the patch in this version of FieldBase.php, and I couldn't in 1.15, so that looks better.
I am concerned about "does not resolve the root cause."
Thanks for your work on this!
Sure. I just ran composer update and it had nothing new.
composer info drupal/office_hours
name : drupal/office_hours
descrip. : Defines a 'weekly office hours' field type, allowing you to specify when an Entity is open or closed.
keywords :
versions : * 1.15.0
type : drupal-module
license : GNU General Public License v2.0 or later (GPL-2.0+) (OSI approved) https://spdx.org/licenses/GPL-2.0+.html#licenseText
homepage : http://drupal.org/project/office_hours
source : [git] https://git.drupalcode.org/project/office_hours.git 8.x-1.15
dist : [zip] https://ftp.drupal.org/files/projects/office_hours-8.x-1.15.zip 8.x-1.15
path : /Users/ethan/Documents/Lando/rpi-registrar/web/modules/contrib/office_hours
names : drupal/office_hours
Drupal Available Updates Report says
Office Hours 8.x-1.15
Includes: Office Hours
Flushing the cache gives me
The website encountered an unexpected error. Try again later.
drush ws gives me
3158 16/Feb 07:57 php Error TypeError: Unsupported operand types: array + null in Drupal\office_hours\Plugin\views\field\FieldBase::viewsFieldData() (line 81 of /app/web/modules/contrib/office_hours/src/Plugin/views/
Ditto: we just updated to 1.15 and it seems to be broken for us as well. I don't see that the patch, or the "construct," are in the new code.
Patch worked for us, too. Thank you!
Drupal 10.2.0
PHP 8.1.26
MariaDB 10.4.25
drupal/webform 6.2.2
Did some digging around. In src/OfficeHoursDateHelper.php in the format() function, if the end time is 0 (midnight) it reformats it to "00:00". Around line 177 it explicitly changes the time. It sets it to "23, 00", which is 11pm, and then tries to replace 23 with 24. Except that the value is "11:00pm" and there's no 23. I'm not sure why it's doing that.