- Issue created by @suegmune
- πΊπΈUnited States suegmune
Did some additional testing: When I downgrade to 1.7.0 it works as intended. But 1.8.0+ it shows 11 PM for midnight.
- πΊπΈUnited States ethangeorgi
Did some digging around. In src/OfficeHoursDateHelper.php in the format() function, if the end time is 0 (midnight) it reformats it to "00:00". Around line 177 it explicitly changes the time. It sets it to "23, 00", which is 11pm, and then tries to replace 23 with 24. Except that the value is "11:00pm" and there's no 23. I'm not sure why it's doing that.
- Status changed to Needs review
over 1 year ago 12:26pm 23 August 2023 - last update
over 1 year ago Patch Failed to Apply - Open on Drupal.org βCore: 10.0.7 + Environment: PHP 8.1 & MySQL 5.7last update
over 1 year ago Waiting for branch to pass - Open on Drupal.org βCore: 10.0.7 + Environment: PHP 8.1 & MySQL 5.7last update
over 1 year ago Waiting for branch to pass - Status changed to Fixed
over 1 year ago 1:03pm 23 August 2023 - π³π±Netherlands johnv
This was still not working for all formatting options.
Automatically closed - issue fixed for 2 weeks with no activity.