Patch #21 - and in extend MR 68 - seemed to work fine at first, but I did encounter an issue.
When the patch is applied, and I try to put a site in to maintenance mode through drush, it does not work.
The command I ran:
drush state:set system.maintenance_mode 1 && drush cr
This caused our deployment pipelines to fail because we rely on this command to put all the sites in maintenance during the deployment.
Can confirm that patch #9 works!
Created a patch file of the MR at time of writing this comment.
Thanks for all the hard work!
Rerolled the lightning_media patch for version 5.0.0.
Just created a patch from the MR so I can apply it in my composer.json.
I hate to come by and just say "same issue here", but that's about the gist of it.
If I can assist with resolving the issue (with some guidance of the maintainer) feel free to reach out!
For now we've just locked the `guzzlehttp/guzzle` library to 7.8.
Same issue here. Any help would be greatly appreciated.
Rerolled the patch again to fix the tests.
Rerolled the patch for version 8.x-1.12
boazpoolman → created an issue.
The patches written for this issue are assuming the "Domain access" field on taxonomies has a machine name of domain_access.
It would make more sense to have assume the machine name is `field_domain_access`. That is the machine name that is provided by the domain_access module itself anyways. I've updated the patch to include this change.
Thanks for looking at this issue Rickard!
I've applied your patch, and removed my `a_` prefix workaround, though sadly the redirect loop still occurs.
What is our next course of action? Do you want me to rebrand this issue to be a feature request?
boazpoolman → created an issue.