🇹🇼Taiwan @peterwcm

berdir → credited peterwcm → .

To recap the original issue, the other contrib - Paragraphs Asymmetric Translation Widgets creates new, independent paragraphs per node translation. However, TMGMT doesn't follow the same flat structure, it creates a translation for a paragraph instead of cloning a completely new one. We were using patch #24 back in D9 and it worked fine. Upon upgrading to D10, we switched to a newer patch #33 and the original issue reoccurs.

I refactored the logic in #24 and added that to patch #33. When the asymmetric mode is on, TMGMT should treat the entity field as 'non-translatable' so it will clone the source entity instead of translating it.

Adding a new config option is a much better solution. I tested and it's working. I just added a comment about a small typo in the PR.

peterwcm → created an issue.

Rerolled for 11.x

peterwcm → changed the visibility of the branch 3469076-d9-sites-are to hidden.

peterwcm → created an issue.

Hi guys,

The source language issue has been raised separately in this issue: https://www.drupal.org/project/tmgmt/issues/3242174 🐛 ContentEntitySource is using entity's source language instead of job's source language when saving Needs review
I think let's help review and test the patch there so we don't feature creep this issue

Regards

Peter

The Paragraphs Legacy Asymmetric widget changes the original language and removes other translations after creating a duplicate of paragraphs. However, the same logic is not found in the hook_entity_translation_create hook, which is used by the Paragraphs (stable) widget. I have copied the same logic to the hook, which seems to remove the redundant data created during the paragraph clone.

Does anyone know why the logic is not added, I wonder if it's on purpose or a mistake.

It's probably related to https://www.drupal.org/project/paragraphs_asymmetric_translation_widgets... →

Taking some code out of the Issue-2992777 merge request

I agree that the root problem is the duplicate data created during translations.

Regarding the patch above, it has two issues:
1. For paragraphs that have only 1 default language, trying to remove the default translation will cause an exception
2. Removing a translation without saving the paragraph doesn't do anything

The "Delete redirects defined in the spreadsheet" option wasn't working as described. I tested and the patch fixed the issue perfectly.

Thank you @anybody :) I have removed unrelated changes and kept it simple. I will continue to do more testing from my end.

peterwcm → changed the visibility of the branch 3249822-translations-checksum-2.1 to hidden.

peterwcm → changed the visibility of the branch 3249822-translations-checksum-1.x to hidden.

peterwcm → changed the visibility of the branch 3249822-translations-checksum-2.x to hidden.

peterwcm → changed the visibility of the branch 2.x to hidden.

My site encountered this error after upgrading from 8.x-4.2 to 5.0.0-alpha3
My setup uses Smart IP and Smart IP MaxMind GeoIP2 binary database modules

Patch #5 works for me

Drupal version: 9.5.11
PHP: 8.1.29

Let's get a new 2.x version that is D10 compatible and drop D8 support from there. For 1.x, let's leave that in D8/D9.

Hi @linhnm,

I think it's a valid request to add in the media library form. However, the module itself is just to provide a Media source plugin, it shouldn't take care of the actual media type creation including all the field-related configs. It's up to sites to decide how they want to create or name the media type.

Checking upon some of the famous media source modules, they don't provide any default field or display configs for the same reasons.
https://www.drupal.org/project/media_entity_facebook →
https://www.drupal.org/project/media_entity_instagram →

Regards

Peter

A new release with D10 support has been released: https://www.drupal.org/project/smartip_language_detection/releases/2.0.0... →

peterwcm → made their first commit to this issue’s fork.

8.x is not going to be D10 compatible

Hi @jeroent

I am looking at the issues and will prepare for a new 2.x release but will probably drop D8 support going forward.

Regards

Peter

Added pull request for the D10 updates and updated the code to use service injections. Tested locally.

Tested locally with the patch and content check using `rendered_entity_full_view` input still works fine

The changes look good, could we merge it and tag a new release for D10 please?

Setting a min-width is probably not scalable because it only supports the default placeholder text. The overflow is caused by the min-width set for .chosen-choices, removing that should fix the overflow issue and it's up to users to set a min-width in their custom implementations.

Tested on our 9.5.11 site and it's working fine. Could you provide more information on this? Make sure you have updated the field widget to use Chosen. Otherwise, even though Chosen will turn your select list into a chosen widget by default, the hooks in chosen_order won't kick in.

locale-language_list-3119280-2.patch is conflicting with 9.5.9, rerolling a new patch

Hi @bgreco,

That would be the same reason as having Media translatable in general I think. There are many cases we would need to translate a media and have it identified as the same Media object. For example, an image with text, a youtube video or a PDF file that is available in different languages.

peterwcm → created an issue.

Thank you @damienmckenna for maintaining this. I saw that all child issues seem to be resolved, will there be more work before this is ready to be released? Just want to get a rough idea of when this will be released so we can make a decision on whether or not to apply some patches for the time being. Cheers.