Account created on 12 July 2017, almost 7 years ago
#

Merge Requests

Recent comments

πŸ‡¦πŸ‡ΊAustralia peterwcm

Let's get a new 2.x version that is D10 compatible and drop D8 support from there. For 1.x, let's leave that in D8/D9.

πŸ‡¦πŸ‡ΊAustralia peterwcm

Hi @linhnm,

I think it's a valid request to add in the media library form. However, the module itself is just to provide a Media source plugin, it shouldn't take care of the actual media type creation including all the field-related configs. It's up to sites to decide how they want to create or name the media type.

Checking upon some of the famous media source modules, they don't provide any default field or display configs for the same reasons.
https://www.drupal.org/project/media_entity_facebook β†’
https://www.drupal.org/project/media_entity_instagram β†’

Regards

Peter

πŸ‡¦πŸ‡ΊAustralia peterwcm

peterwcm β†’ made their first commit to this issue’s fork.

πŸ‡¦πŸ‡ΊAustralia peterwcm

8.x is not going to be D10 compatible

πŸ‡¦πŸ‡ΊAustralia peterwcm

Hi @jeroent

I am looking at the issues and will prepare for a new 2.x release but will probably drop D8 support going forward.

Regards

Peter

πŸ‡¦πŸ‡ΊAustralia peterwcm

Added pull request for the D10 updates and updated the code to use service injections. Tested locally.

πŸ‡¦πŸ‡ΊAustralia peterwcm

Tested locally with the patch and content check using `rendered_entity_full_view` input still works fine

πŸ‡¦πŸ‡ΊAustralia peterwcm

The changes look good, could we merge it and tag a new release for D10 please?

πŸ‡¦πŸ‡ΊAustralia peterwcm

Setting a min-width is probably not scalable because it only supports the default placeholder text. The overflow is caused by the min-width set for .chosen-choices, removing that should fix the overflow issue and it's up to users to set a min-width in their custom implementations.

πŸ‡¦πŸ‡ΊAustralia peterwcm

Tested on our 9.5.11 site and it's working fine. Could you provide more information on this? Make sure you have updated the field widget to use Chosen. Otherwise, even though Chosen will turn your select list into a chosen widget by default, the hooks in chosen_order won't kick in.

πŸ‡¦πŸ‡ΊAustralia peterwcm

locale-language_list-3119280-2.patch is conflicting with 9.5.9, rerolling a new patch

πŸ‡¦πŸ‡ΊAustralia peterwcm

Hi @bgreco,

That would be the same reason as having Media translatable in general I think. There are many cases we would need to translate a media and have it identified as the same Media object. For example, an image with text, a youtube video or a PDF file that is available in different languages.

πŸ‡¦πŸ‡ΊAustralia peterwcm

Thank you @damienmckenna for maintaining this. I saw that all child issues seem to be resolved, will there be more work before this is ready to be released? Just want to get a rough idea of when this will be released so we can make a decision on whether or not to apply some patches for the time being. Cheers.

Production build 0.69.0 2024