What is the use case for having the duplicates_checksum field translatable in the first place? It seems like this issue could be solved by making the field not translatable.
- 🇹🇼Taiwan peterwcm
Hi @bgreco,
That would be the same reason as having Media translatable in general I think. There are many cases we would need to translate a media and have it identified as the same Media object. For example, an image with text, a youtube video or a PDF file that is available in different languages.
- Status changed to Needs work
over 1 year ago 1:22pm 23 May 2023 - 🇩🇪Germany Anybody Porta Westfalica
Hi and thanks for the discussion!
see if it's better to just check if the duplicates belong to the same entity, e.g. translations
Exactly that's the correct approach. If there's a duplicate, it should be checked, if it's exactly the same entity (ID).
- 🇹🇼Taiwan peterwcm
peterwcm → changed the visibility of the branch 2.x to hidden.
- 🇹🇼Taiwan peterwcm
peterwcm → changed the visibility of the branch 3249822-translations-checksum-2.x to hidden.
- 🇹🇼Taiwan peterwcm
peterwcm → changed the visibility of the branch 3249822-translations-checksum-1.x to hidden.
- 🇹🇼Taiwan peterwcm
peterwcm → changed the visibility of the branch 3249822-translations-checksum-2.1 to hidden.
- Merge request !16Issue #3249822: Exclude duplicates from the same entity → (Open) created by peterwcm
- Status changed to Needs review
7 months ago 8:27am 20 June 2024 - 🇩🇪Germany Anybody Porta Westfalica
Thank you @peterwcm - this looks promising! We should all test it.
- 🇹🇼Taiwan peterwcm
Thank you @anybody :) I have removed unrelated changes and kept it simple. I will continue to do more testing from my end.