@serverjohn

serverjohn → created an issue.

This is my first time supplying a patch... I have removed the title attribute.

Some information on why this change makes sense. WCAG H33: Supplementing link text with the title attribute.

The objective of this technique is to demonstrate how to use a title attribute on an anchor element to provide additional text describing a link. The title attribute is used to provide additional information to help clarify or further describe the purpose of a link. If the supplementary information provided through the title attribute is something the user should know before following the link, such as a warning, then it should be provided in the link text rather than in the title attribute.

serverjohn → created an issue.

I received this error too. I can confirm that the patch solved the issue.
Thank you!

I have never done a patch before on an issue before but this works for me:

    if ($is_allowed) {
      $source_field_definition = $media_type->getSource()->getSourceFieldDefinition($media_type);
      if ($source_field_definition){
        if ($source_field_definition->getItemDefinition()->getClass()) {
          $item_class = $source_field_definition->getItemDefinition()->getClass();
          $is_allowed = is_a($item_class, FileItem::class, TRUE);
        }
      }
    }

I am having the same issue when trying to add media. The patch did not work for me either. Here is the full error:

The website encountered an unexpected error. Please try again later.

Error: Call to a member function getItemDefinition() on null in Drupal\lightning_media\Plugin\EntityBrowser\Widget\FileUpload->isAllowedType() (line 252 of modules/contrib/lightning_media/src/Plugin/EntityBrowser/Widget/FileUpload.php).
array_filter(Array, Array) (Line: 243)
Drupal\lightning_media\Plugin\EntityBrowser\Widget\EntityFormProxy->getAllowedTypes() (Line: 305)
Drupal\lightning_media\Plugin\EntityBrowser\Widget\EntityFormProxy->access() (Line: 309)
Drupal\entity_browser\Entity\EntityBrowser->Drupal\entity_browser\Entity\{closure}('044d2af7-314b-4830-8b6d-64896bbb861e')
array_filter(Array, Object) (Line: 310)
Drupal\entity_browser\Entity\EntityBrowser->getFirstWidget() (Line: 271)
Drupal\entity_browser\Form\EntityBrowserForm->getCurrentWidget(Object) (Line: 160)
Drupal\entity_browser\Form\EntityBrowserForm->buildForm(Array, Object)
call_user_func_array(Array, Array) (Line: 536)
Drupal\Core\Form\FormBuilder->retrieveForm('entity_browser_media_browser_form', Object) (Line: 283)
Drupal\Core\Form\FormBuilder->buildForm(Object, Object) (Line: 104)
Drupal\autosave_form\Form\AutosaveFormBuilder->buildForm(Object, Object) (Line: 73)
Drupal\Core\Controller\FormController->getContentResult(Object, Object)
call_user_func_array(Array, Array) (Line: 123)
Drupal\Core\EventSubscriber\EarlyRenderingControllerWrapperSubscriber->Drupal\Core\EventSubscriber\{closure}() (Line: 592)
Drupal\Core\Render\Renderer->executeInRenderContext(Object, Object) (Line: 124)
Drupal\Core\EventSubscriber\EarlyRenderingControllerWrapperSubscriber->wrapControllerExecutionInRenderContext(Array, Array) (Line: 97)
Drupal\Core\EventSubscriber\EarlyRenderingControllerWrapperSubscriber->Drupal\Core\EventSubscriber\{closure}() (Line: 181)
Symfony\Component\HttpKernel\HttpKernel->handleRaw(Object, 1) (Line: 76)
Symfony\Component\HttpKernel\HttpKernel->handle(Object, 1, 1) (Line: 58)
Drupal\Core\StackMiddleware\Session->handle(Object, 1, 1) (Line: 48)
Drupal\Core\StackMiddleware\KernelPreHandle->handle(Object, 1, 1) (Line: 106)
Drupal\page_cache\StackMiddleware\PageCache->pass(Object, 1, 1) (Line: 85)
Drupal\page_cache\StackMiddleware\PageCache->handle(Object, 1, 1) (Line: 48)
Drupal\Core\StackMiddleware\ReverseProxyMiddleware->handle(Object, 1, 1) (Line: 51)
Drupal\Core\StackMiddleware\NegotiationMiddleware->handle(Object, 1, 1) (Line: 51)
Drupal\Core\StackMiddleware\StackedHttpKernel->handle(Object, 1, 1) (Line: 704)
Drupal\Core\DrupalKernel->handle(Object) (Line: 19)

I ran into this problem and the https://evolvingweb.ca/blog/resizing-fields-drupal-8-without-losing-data article worked great. It even links to the git repository for it so you can copy past from that with minor edits.

The following lines are not needed:

...
use Drupal\field\Entity\FieldConfig;
...
// Deleting field.
FieldConfig::loadByName('entity_type', 'bundle', 'field_name')->delete();

The delete on the field is dependent on FieldStorageConfig and is deleted as well. In fact, if you execute in this order you will get a null error when deleting the field.

If you want to others that look at your code to know what is going on you could switch the order and then you won't have an error.

use Drupal\field\Entity\FieldStorageConfig;
use Drupal\field\Entity\FieldConfig;

// Deleting field.
FieldConfig::loadByName('entity_type', 'bundle', 'field_name')->delete();

// Deleting field storage.
FieldStorageConfig::loadByName('entity_type', 'field_name')->delete();

I ran into the same problem. I can confirm that this little code change makes a prefix work as well as a suffix. I can't wait until this is merged! Thank you!

#10 works for me setting a moderation state to review on Drupal 9.5.9.

$form_state->setValue('moderation_state', ['0' => [ 'value' => 'review' ] ] ); //Works!

Additionally, I started off with getting the entity and setting the value with:

$entity = $form_state->getFormObject()->getEntity();
$entity->set('moderation_state', 'review');

This didn't even throw out an error. It just didn't work. It wasn't until I tried:

$form_state->setValue('moderation_state', 'review');

and finally the above error and I ended up here.

serverjohn → created an issue.