Hi, kevinquillen!
I am away from a computer at the moment, but when I get a chance, I'll review and merge this in to prepare a D11 release. Thanks for the heads-up and the MR.
Created MR above. Added patch from MR to this comment.
joum → created an issue.
Ended up reverting colorbox to 2.0.2 instead of using 2.1.1 and this was solved. CLosing as it is Colorbox-related and doesn't belong in this queue.
Patch for V5 here.
Closing this issue; misunderstood the dependency chain, patch needs to be added to the Rocketship Profile.
After attempting to solve the issue with the suggested approach, it worked, but now the Colorbox module isn't adding the previous/next gallery navigation controls.
So basically, the steps in my resolution approach were:
- I created simple responsive image styles to mimic the DRImage ones being used.
- I created new Image Media view modes to be used in place of the current "1:1 Aspect Ratio" and "Original Aspect Ratio" ones, which in turn use the new responsive image styles created before
- I configured the Photo Gallery Block type "Grid" and "Masonry" view modes to use the new Image Media view modes accordingly and set the "Colorbox grouping" settings to match what was in place before (showed navigation, but didn't load image in fullscreen).
I have also tried changing the Colorbox Responsive field formatter gallery grouping settings, but none of the options worked as intended neither.
I wonder if there is any custom JS initialising Colorbox and overriding the grouping setting?
joum → created an issue.
the_g_bomb → credited joum → .
Hi @markdorison!
I've been working on a D7->D11 migration and can confirm that MR35 worked for me, but had to massage it a bit and require the league/csv package by itself because using the repo for the MR with the commit hash didn't pick it up automatically - I'm guessing due to this method of doing things not resolving dependencies correctly.
Not sure about D10, though, sorry.
Can confirm this still applies cleanly on Drupal 10.1.6.
Does it only require automated tests to move forward to RTBC?
Can confirm #128 applies cleanly and works on Drupal 10.1.6
Can confirm #10 works for me, too.
Can this be merged in and released?
After importing my encryption-relevant configuration on a unencrypted database for testing, I was getting an Ajax console error:
"
An AJAX HTTP error occurred.
HTTP Result Code: 200
Debugging information follows.
Path: /admin/config/system/field-encrypt/entity-types?ajax_form=1
StatusText: OK
ResponseText:
Warning: array_flip(): Can only flip string and integer values, entry skipped in /var/www/html/docroot/core/lib/Drupal/Core/Entity/EntityStorageBase.php on line 278
The website encountered an unexpected error. Please try again later."This prevented me from altering the entity field encryption configuration.
I've applied the patch and tested again on Drupal 10.1.6 and I no longer get this error.
I propose moving to RTBC.
Merged in. Will create a new release now.
Can confirm #42 also works on core 9.5.11. I propose this is moved to RTBC.
Consolidated patch for this issue and ✨ Inherit libraries from base themes Fixed merged in above commit; had been RTBC'd; marking as Fixed.
Consolidated patch for this issue and 🐛 Module only picks up components from the entities first layout canvas field Fixed merged in above commit; had been RTBC'd; marking as Fixed.
Cheers, @rudam!
Hope I can help move things along! 💪🏼
I was also trying to contact rudam about this issue directly via his profile's contact form, but unfortunately it wasn't possible.
Can confirm the patch on #1 works correctly using Drupal Core version 9.5.2 and this module's version 5.1.0.
When the module is first installed and there's no configuration available, a _lot_ of warnings are throw for each field access hook call. If, for example, a content type's entity form has any Ajax calls (for instance, autocomplete entity reference widgets) those don't work anymore because of the warnings reaching the Ajax response as well), so this is rather critical.
The patch correctly introduces simple sanity checks when loading the module's configuration objects to check if those actually exist before proceeding to make changes.
Changed priority to critical and moved the status to RTBC.