πŸ‡ΊπŸ‡ΈUnited States @matthew.h

Account created on 14 June 2016, about 8 years ago
#

Merge Requests

Recent comments

πŸ‡ΊπŸ‡ΈUnited States matthew.h

Switching back to active because I just realized that the empty check is specifically for checking max-snippet, max-video-preview, max-image-preview, and unavailable_after not the indexing stuff

πŸ‡ΊπŸ‡ΈUnited States matthew.h

I believe it was due to the validateTag method on the Robots class checking if the indexing value was empty before setting it. However if the indexing options are unchecked it is set as 0, which php considers empty. Changed it so it checks if it's null instead of if it's empty.

πŸ‡ΊπŸ‡ΈUnited States matthew.h

amy.h β†’ made their first commit to this issue’s fork.

πŸ‡ΊπŸ‡ΈUnited States matthew.h

@ruslan-piskarov what was your local issue? I've run into the same error

πŸ‡ΊπŸ‡ΈUnited States matthew.h

Merge requested and ready for review. My first merge request was done by accident to the wrong branch. Branch 3367781- is the intended branch.

πŸ‡ΊπŸ‡ΈUnited States matthew.h

matthew.h β†’ made their first commit to this issue’s fork.

πŸ‡ΊπŸ‡ΈUnited States matthew.h

Implemented change in fork. Ready for review

πŸ‡ΊπŸ‡ΈUnited States matthew.h

matthew.h β†’ made their first commit to this issue’s fork.

πŸ‡ΊπŸ‡ΈUnited States matthew.h

I'm at Drupalcon. Looked at the code and tested manually. Code change looked fine. See attached screenshot from testing.

Production build 0.69.0 2024