Switching back to active because I just realized that the empty check is specifically for checking max-snippet, max-video-preview, max-image-preview, and unavailable_after not the indexing stuff
I believe it was due to the validateTag method on the Robots class checking if the indexing value was empty before setting it. However if the indexing options are unchecked it is set as 0, which php considers empty. Changed it so it checks if it's null instead of if it's empty.
matthew.h β created an issue.
@ruslan-piskarov what was your local issue? I've run into the same error
Can we make a release for this?
Ready for review
matthew.h β created an issue.
Merge requested and ready for review. My first merge request was done by accident to the wrong branch. Branch 3367781- is the intended branch.
matthew.h β created an issue.
matthew.h β made their first commit to this issueβs fork.
Implemented change in fork. Ready for review
matthew.h β made their first commit to this issueβs fork.
I'm at Drupalcon. Looked at the code and tested manually. Code change looked fine. See attached screenshot from testing.