Understood. I just pushed an update to restore the previous hook version (retaining fixed character replacement) and duplicated it with an incremented number.
Just to confirm, we'd prefer two update hooks so they both trigger instead of just incrementing the existing hook so it triggers again for users who already applied the previous version?
I incrementing the existing hook to force it to run again for users who applied the previous version but I can revert that change and duplicate the hook if you prefer. Just let me know and I'll get the MR updated. Thanks!
There was an errant deletion in my prior MR that removed the upcast view classes property. This causes a breaking error when editing some grid content, a grid within another div for example ("Cannot read properties of undefined" / "CKEditorError: e is undefined"). I've submitted a MR that restores the classes property to resolve the issue. I apologize for the oversight in the original changes.
MR sent, just let me know if there's any adjustments needed. Thanks!
The upgrade hook inverts the character replacement for the prefixes. In uswds_ckeditor_integration_update_103001() line 27 is:
$breakpoints[$key]['prefix'] = str_replace('-', '_', $breakpoint['prefix']);
but should be:
$breakpoints[$key]['prefix'] = str_replace('_', '-', $breakpoint['prefix']);
chrislarrycarl → created an issue.
Adding a comment to note that upgrading to Drupal core v10.3.1 does not result in any change to this issue.