- Issue created by @chrislarrycarl
- Assigned to smustgrave
- πΊπΈUnited States smustgrave
May have time this evening for a quick hook.
- 108833e5 committed on 3.0.x
Issue #3466965 by chrislarrycarl: Version 3 breakpoint prefix doesn't...
- 108833e5 committed on 3.0.x
- Status changed to Fixed
3 months ago 12:34am 28 August 2024 - πΊπΈUnited States chrislarrycarl
The upgrade hook inverts the character replacement for the prefixes. In uswds_ckeditor_integration_update_103001() line 27 is:
$breakpoints[$key]['prefix'] = str_replace('-', '_', $breakpoint['prefix']);
but should be:
$breakpoints[$key]['prefix'] = str_replace('_', '-', $breakpoint['prefix']);
- Status changed to Needs review
3 months ago 1:35pm 3 September 2024 - Status changed to Needs work
3 months ago 3:25pm 3 September 2024 - Status changed to Needs review
3 months ago 12:37pm 4 September 2024 - πΊπΈUnited States chrislarrycarl
MR sent, just let me know if there's any adjustments needed. Thanks!
- Status changed to Needs work
3 months ago 1:49pm 5 September 2024 - πΊπΈUnited States smustgrave
This is already out so will need a new update hook even if just a copy
- πΊπΈUnited States chrislarrycarl
Just to confirm, we'd prefer two update hooks so they both trigger instead of just incrementing the existing hook so it triggers again for users who already applied the previous version?
I incrementing the existing hook to force it to run again for users who applied the previous version but I can revert that change and duplicate the hook if you prefer. Just let me know and I'll get the MR updated. Thanks!
- πΊπΈUnited States smustgrave
But if some haven't updated we would be skipping a hook number.
- Status changed to Needs review
3 months ago 2:58pm 5 September 2024 - πΊπΈUnited States chrislarrycarl
Understood. I just pushed an update to restore the previous hook version (retaining fixed character replacement) and duplicated it with an incremented number.
- Status changed to Fixed
3 months ago 4:13pm 5 September 2024 - πΊπΈUnited States smustgrave
Merge train started.
Once merged will do another release, thanks for finding this.
Automatically closed - issue fixed for 2 weeks with no activity.