For 2.x-dev the keeping old option allowfullscreen is ok.
For the new 3.x branch I would skip it - allow="...fullscreen..." is enough for the future.
Acknowledged.
not necessary you can add additional scripts with the right permissions, via a block, define it a lttle bit more generic and will work.
neffets β made their first commit to this issueβs fork.
I made a cleanup of the code and omitting the empty "__construct" and "create" methods, following the procedure like in: web/core/modules/field/src/Plugin/migrate/process/d7/FieldInstanceSettings.php
Please try 8.x-2.x dev version.
Or get the 1 file directly: https://git.drupalcode.org/project/iframe/-/blob/8.x-2.x/src/Plugin/migr...
no comment, so i expect, thats now working
Its working for me:
Merge in next release
Thanx, merged to dev-Version
You can use the URL of your new Tab and put it directly as iframe-url, so you don't need another field-in-field-solution.
Thanx for the first real test.
So we can add further.
neffets β made their first commit to this issueβs fork.
key now checked with !empty
You can now try the dev-version, I change there from CckFilePluginBase to plain FieldPluginBase because the own Cck version is deprecated since drupal 8.4.
I have no test case here by myself.
What is the URI of the iframe?
Such errors cann occur too in cases, where the original site (addressed by the iframe-url) ist issueing an X-Iframe-Header by itself
Patch applied
Works as designed.
The formular-switcher allows
* "URL with width and height" - asking for url and width and height
* "URL with height" - asking for url and height (no width, so its using width 100% of outer element)
* "URL only" - asking the user only for URL and using default width and height given by the admin
The "title" is always needed for accessibility issues. And asked for in all three cases;
do you have error in opyr, or what ist not working with the iframe module.
Can you reproduce the failure with plain iframe and URL/label/title/,...?
Fixed in 8.x-2.23
Fixed in 8.x-2.23
I have a problem with your definition of "length".
Here we are using an "iframe"-element defined in https://developer.mozilla.org/en-US/docs/Web/HTML/Element/iframe
So that values as plain number (e.g. 701) are (1) normal usage and (2) implicite an px-Value
So we would need for *ratio* another approach.
Whats about an explicite rule: width="ratio" or width="4:3" simply *width: auto* height will then be ignored and the respocive-scheme is used.
Can you provide an example or a test-page?.
Which URL you want to set as iframe-URL?
For a callback function you can provide simply "console.log"
(this does nothing, but shows all given parameters in the Browser Console, which you get as paramters to the callback)
1) I like the "sandbox" attribute, but its dangerous.
[sandbox atrribute](https://developer.mozilla.org/en-US/docs/Web/HTML/Element/iframe#sandbox)
If its set, then the default is very restrictive (no forms, no downloads, no scripts, no alerts, no popups, ...)
We should discuss what we suggest as "default" Options to enable.
I would suggest at minimum: "allow-downloads,allow-forms"
What is your opinion?
2) "reffererpolicy" would be OK with the default "strict-origin-when-cross-origin" (this is the normal browser default too)
neffets β made their first commit to this issueβs fork.
Merged
neffets β made their first commit to this issueβs fork.