Oslo, Norway
Account created on 27 June 2008, over 16 years ago
#

Merge Requests

Recent comments

πŸ‡³πŸ‡΄Norway truls1502 Oslo, Norway

We experienced the same issue when upgrading to Commerce 2.40 (including 2.38) while migrating from Drupal 9 to Drupal 10.

It seems likely that #3418825 πŸ› Exception logging is not working due to a typo in doOrderPreSave() Fixed might be the root cause, but I haven't fully investigated it. However, we still need to ensure that logger.channel.commerce_order exists, especially in CI/CD pipelines and production environments where developers do not have access to run drush cache:rebuild.

We have created a simple patch that ensures the logger is always registered before use in OrderStorage::createInstance(), preventing pipeline failures.

Would it be possible to integrate this fix? πŸš€

πŸ‡³πŸ‡΄Norway truls1502 Oslo, Norway

truls1502 β†’ made their first commit to this issue’s fork.

πŸ‡³πŸ‡΄Norway truls1502 Oslo, Norway

Released!

πŸ‡³πŸ‡΄Norway truls1502 Oslo, Norway

Released, and thank you for your patience.

πŸ‡³πŸ‡΄Norway truls1502 Oslo, Norway

truls1502 β†’ made their first commit to this issue’s fork.

πŸ‡³πŸ‡΄Norway truls1502 Oslo, Norway

Adding a temporary patch to able to use PHP 7.4

πŸ‡³πŸ‡΄Norway truls1502 Oslo, Norway

The logo is now fixed.

πŸ‡³πŸ‡΄Norway truls1502 Oslo, Norway

truls1502 β†’ made their first commit to this issue’s fork.

πŸ‡³πŸ‡΄Norway truls1502 Oslo, Norway

I apologise, I did not see that you had committed it directly to the branch. I was on the phone and checked only the changes in the MR!12. So just look away from my last question πŸ˜…

πŸ‡³πŸ‡΄Norway truls1502 Oslo, Norway

Maybe I am mistaken, should we not replace the old module swiftmailer with https://www.drupal.org/project/symfony_mailer β†’ ? What are your thoughts about it?

πŸ‡³πŸ‡΄Norway truls1502 Oslo, Norway

There exists already a PR

πŸ‡³πŸ‡΄Norway truls1502 Oslo, Norway

Thanks for the meeting. Looking forward to the next one!

Production build 0.71.5 2024