Hello! ai seems like an awesome project, thank you for sharing.
For our particular use case and many others, it may not make sense to switch to the ai module because we aren't using LLM features. The immediate goal of vertex_ai_search is to provide users a way to switch to Agent Builder from Google's Programmable Search Console; many of these users may not be turning on the advanced LLM features in production for a long time and may just be looking for continuity of custom search for their sites.
vertex_ai_search is purpose-built to help users easily integrate with Google Cloud Platform & agent builder for hitting a custom search endpoint, whereas ai seems primarily focused on integration with AI providers for the intents and purposes of content creation. I will close this issue for now, but I will certainly keep an eye on the ai module and see if we have an opportunity for intersection in the future.
TimoZura β credited ari.saves β .
ari.saves β created an issue.
TimoZura β credited ari.saves β .
This patch is working well for me, thank you @timurtripp! I may add a little padding when I get a moment for readability; also I am curious -- if I wanted to sort these into categories, would that be in the icon families metadata? Thanks again for your time on this issue!
Hello Tim! Custom icons use the fak
class; for example, the custom-icons.css file defines them like this:
.fak.fa-learn::before, .fa-kit.fa-learn::before { content: "\e000"; }
ari.saves β created an issue.
The patch in #20 resolves the e.trim error for me! Thanks so much :)
I'm still having some issues getting custom icons to show in the plugin window. Wondering if my metadata is corrupted.
Here's some metadata for a custom icon:
learn:
label: learn
styles:
- custom
unicode: e000
voted: false
vs the metadata for a FA icon:
key:
aliases:
unicodes:
composite:
- 1f511
secondary:
- 10f084
changes:
- 1.0.0
- 5.0.0
- 5.10.1
- 6.0.0-beta1
- 6.0.0
- 6.2.0
- 6.3.0
- 6.4.0
- 6.5.0
label: Key
search:
terms:
- key
- lock
- password
- private
- secret
- unlock
styles:
- solid
unicode: f084
voted: false
So a lot more attributes there for the FA icon vs our custom kit icons; wondering which of these attributes may be required and if that's the issue.
+1 I'm also having this issue; same behavior, though I get a console error too:
2icon.js?s8gzke:1 Uncaught (in promise) TypeError: e.trim is not a function
at icon.js?s8gzke:1:2741
at Array.map (<anonymous>)
at a (icon.js?s8gzke:1:2731)
at icon.js?s8gzke:1:3604
at Generator.next (<anonymous>)
at r (icon.js?s8gzke:1:2138)