🇺🇸United States @cainaru

@jurgenhaas Unsure if this might help narrow the scope of determining “what script could be adding the is-active to the ‘Shortcuts’ link at the top”, but the issue only seems reproducible as long as the “Navigation” module is enabled. I couldn’t reproduce the issue if I uninstall “Navigation” and configure the Gin theme to use “ New Drupal Navigation”.

It makes me wonder if there is some sort of collision happening somewhere between “Navigation” and “Gin Admin Theme” with regards to the “Shortcuts” link at the top? I didn’t have a chance yet to dig into any of the scripts there, but might be a good place for someone who has way more JavaScript knowledge to start debug.

Congratulations on the new design! It does feel refreshing, and full of a very playful and whimsical nature; it is definitely growing on me!

I have some constructive feedback that I haven't seen anyone else mention yet:

For links that are styled by the .button--primary class, the text of the link is visually unreadable when focusing on the link (e.g., when navigating the page via keyboard). When the link is in the focus state, the text color gets set to the same color as the background-color. I'm using Chrome 131 on macOS (Sequoia).

Screenshots below:

From https://new.drupal.org/about/11

From https://new.drupal.org/drupal-cms/release-candidate

Steps to reproduce:

1. On a laptop or desktop in browser, visit any pages that use the new design (e.g., https://new.drupal.org/home, https://new.drupal.org/about/11, etc.).
2. Using the Tab key on your keyboard, navigate to the "Get Started" link that is in the main menu to activate the focus state.
3. Verify that even when focused, you can still read the text "Get Started".
   1. Expected result: The "Get Started" text should still be visually readable when focused on.
   2. Actual result: The "Get Started" text is no longer visually readable when focused on.
4. Continue to Tab throughout the page to focus on other styled links that are present on the page to verify that text is still readable even when focused.

Recommended solution:

1. Verify with the style guide or design system being used what the intended focus state styling for buttons or links that use the .button--primary class is supposed to be (e.g., on focus, should the text color be set to var(--drupal-white), or should the text color remain var(--drupal-navy) but the background-color changes to var(--drupal-white), or something else?) .
2. Once the intended focus state styling for .button--primary is verified, add the appropriate styling for .button--primary:focus.

breidert → credited cainaru → .

The only con I can see to the usage of “Install” is that, to some end users, that might imply that there must be some “Uninstall” mechanism to recipes (similar to installing/uninstalling an app on your phone or computer).

cainaru → created an issue.

+ My Ukrainian relatives on my dad’s side are still under threat, the war is not over yet. Let’s not become desensitized please

cainaru → created an issue.

A while back when testing this, I noticed that other feeds that are using HTTP Basic Auth, but not Oauth, start failing with this patch. I wonder if modifying the submitConfigurationForm like the following might help (particularly with the failing tests) ?

  public function submitConfigurationForm(array &$form, FormStateInterface $form_state, FeedInterface $feed = NULL) {
    $feed->setSource($form_state->getValue('source'));
    // Only submit these if the feed has the Oauth option present.
    if (isset($form_state->getValue('authorization_options')['feed_authorization_setting'])) {
      $feed_config = [
        'feed_authorization_setting' => $form_state->getValue('authorization_options')['feed_authorization_setting'],
        'access_token_url' => $form_state->getValue('authorization_options')['access_token_url'],
        'grant_type' => $form_state->getValue('authorization_options')['grant_type'],
        'client_id' => $form_state->getValue('authorization_options')['client_id'],
        'scope' => $form_state->getValue('authorization_options')['scope'],
        'username' => $form_state->getValue('authorization_options')['username'],
      ];
      $client_secret = $form_state->getValue('authorization_options')['client_secret'];
      $password = $form_state->getValue('authorization_options')['password'];

      // Only save the client secret and/or password if they have been changed.
      if (!empty($client_secret)) {
        $feed_config['client_secret'] = $client_secret;
      }
      if (!empty($password)) {
        $feed_config['password'] = $password;
      }
      $feed->setConfigurationFor($this->plugin, $feed_config);
    }
  }

And perhaps setting the feed_authorization_setting to FALSE in defaultFeedConfiguration()?