πŸ‡¬πŸ‡§United Kingdom @james hawthorn-byng

Account created on 18 October 2014, about 10 years ago
#

Recent comments

πŸ‡¬πŸ‡§United Kingdom james hawthorn-byng

Tested and merged the patches. Will get a new release out asap.

πŸ‡¬πŸ‡§United Kingdom james hawthorn-byng

If anyone looking for a patch for the current composer version, I have attached a patch for version 1.01

πŸ‡¬πŸ‡§United Kingdom james hawthorn-byng

I'm also experiencing this issue and have yet to find the cause or an acceptable work around.
@alex9000 did you ever find a solution?

πŸ‡¬πŸ‡§United Kingdom james hawthorn-byng

Can confirm this is still an issue in version 3.4 (using Drupal 9.5).
The errors seem to go away when you disable the `purge_processor_lateruntime` module which may be partially be explained by https://www.drupal.org/project/purge/issues/3264141 β†’ . It seems that the fact that the Lateruntime module now uses kernel.terminate rather than kernal.finish, means that it runs on every drush command, sometimes causing this error.

πŸ‡¬πŸ‡§United Kingdom james hawthorn-byng

Rerolling the patch as that last one was done on branch 4.4

πŸ‡¬πŸ‡§United Kingdom james hawthorn-byng

I have also experienced this issue and the comment in #7 lead me to the cause, or at least our cause.

It seems that even though the field description text for Cookies in a category shows an example with spaces between the cookies, this in fact stops all the cookies from working in the snippet that is injected with the exception of the first cookie that usually doesn't have a space before it.

The attached patch adds a new function to the AbstractCCCConfig class to trim any spaces from around each of the cookie names. It also adds a unit test as proof that it doesn't break anything.

πŸ‡¬πŸ‡§United Kingdom james hawthorn-byng

Thanks for flagging this up and patching.
Can confirm this fixes the issue on the latest version of Gin admin theme.

Committing, closing and crediting.

πŸ‡¬πŸ‡§United Kingdom james hawthorn-byng

Thanks for pointing this out, patching and reviewing.
The sort/save seemed to be working on Claro, but could replicate using the Gin admin theme.
Can confirm patch #3 works and applies ok.

Committing, closing and giving credit.

πŸ‡¬πŸ‡§United Kingdom james hawthorn-byng

Thanks for pointing this out, patching and reviewing!
Granting credit and merging this in.

πŸ‡¬πŸ‡§United Kingdom james hawthorn-byng

@smustgrave the latest patch doesn’t apply to my 9.4.7 via composer because of the change to the .gitignore file.
Once I removed that it applied fine. I might be wrong, but I don't think this module should be affecting that file?

Production build 0.71.5 2024