Penza
Account created on 3 October 2014, about 10 years ago
#

Merge Requests

Recent comments

πŸ‡·πŸ‡ΊRussia a.kovrigin Penza

We could simplify the way of determining the asset route via `@current_route_match` service.

πŸ‡·πŸ‡ΊRussia a.kovrigin Penza

I'm facing an issue when observer does nothing when no DOM changes happens on page load.

Usage of MutationObserver is a great option here, but shouldn't bindAjaxLinks() be called anyway, so we'll have processed .use-ajax links at the page loaded stage and on DOM mutation level?

πŸ‡·πŸ‡ΊRussia a.kovrigin Penza

Metatags from this module will be applied for webform page iteself (click View on any webform at /admin/structure/webform).

πŸ‡·πŸ‡ΊRussia a.kovrigin Penza

@fishfree, could you please clarify what component level means here?

πŸ‡·πŸ‡ΊRussia a.kovrigin Penza

a.kovrigin β†’ made their first commit to this issue’s fork.

πŸ‡·πŸ‡ΊRussia a.kovrigin Penza

Another way to fix this is to apply once() for the links instead of body

πŸ‡·πŸ‡ΊRussia a.kovrigin Penza

@batkor did a great job here, thanks a lot!

But there is an issue: if you open two tabs in browser with different node's edit form and try to edit the metatags from the first tab and then edit metatagds on the second tab, the values in the second tab's modal will be the same as the first one.

This patch fixes this issue.

πŸ‡·πŸ‡ΊRussia a.kovrigin Penza

It can be a situation, when there is no roles key in $form['account'] array on form submission which causes the fatal error.
The patch fixes the issue.

πŸ‡·πŸ‡ΊRussia a.kovrigin Penza

The provided patch allows to use markup for flag messages

πŸ‡·πŸ‡ΊRussia a.kovrigin Penza

It is a great idea to notice content managers about this behaviour.

The following are not actually a security but general advices:

  1. You can simply use MODULENAME_form_node_form_alter() here
  2. I'm pretty sure that entity can be retrived with $form_state->getFormObject()->getEntity() here
  3. If you use setErrorByName() method you should provide the actual form element key for the first parameter
  4. In case when $original_alias == $alias your method returns nothing (void). You might consider the approach when your method ends with return $original_alias != $alias; so you won't need to use isset() in the validation function
  5. I belive you would like to change the class description :)
πŸ‡·πŸ‡ΊRussia a.kovrigin Penza

@KarimBou you are able to translate webform metatags just like any other on /admin/config/search/metatag

πŸ‡·πŸ‡ΊRussia a.kovrigin Penza

Here is the patch fixes Drupal 10 compatibility issues

πŸ‡·πŸ‡ΊRussia a.kovrigin Penza

The attached patch includes all fixes for Drupal 10 compatibility

πŸ‡·πŸ‡ΊRussia a.kovrigin Penza

Proivded patch fixes compatibility issues

Production build 0.71.5 2024