🇦🇷Argentina @anacolautti

I tested this issue again in a Drupal 10.1.7, and could not reproduce it anymore.

This is a screenshot of the database in each of the steps mentioned in the ticket:

Could it be, that this got fixed after fixing one of the related tickets?

Thank you very much @sumit-k. This will be in the next release, a week from now (1st April).

I added 2 fields in the settings form, allowing users to enter (version controlled) paths to images.
This overrides the CSS background-image style attribute.

I made some other changes:
- at the JS I changed some selectors. I realized I was using them wrong.
- at the original CSS I changed the background-size attribute of the icons, and set it to "contain". This works better with different icons.

I know this is a minor feature, but I believe this would provide users more flexibility.
I'm thinking of allowing file uploads as well in the next iteration, like I said in the ticket description a while ago.

I'd appreciate if someone could test this.

I know I'm skipping steps here, but I believe this issue is fixed with this change. I'll go ahead and close this. Please feel free to reopen if I'm mistaken.

On the merge request is an attempted fix. I tested this on fresh D9 and D10 installs.
Please take a look.

I missed the fact that you had already proposed a MR (because the status was "new" and I was on automatic...). Although I was not able to reproduce the issue, I came to the same resolution as you from looking at other similar issues. I tested your fix in both Drupal 9 and 10. Thank you for your work, I merged your commit and I'm closing this issue.

Thank you for reporting this. I'm on it.

Hi, Thank you Janner for reporting this. I'm not sure I understand, when you say "status of the button", do you mean the aria-label? I see it's being affected. Look at this video: https://nimb.ws/csVh64

I'll attempt a fix.

Marking this as won't fix. This is not a module issue. In recent updates, Last Pass fixed their behavior. See screnshot, on a fresh Drupal install.

Thank you for your work! This patch has been commited to the 6.0.x dev version.

Sorry, I've been a bit busy lately and it took a while.
Thank you for your contribution to this module. Your patch is now in the 6.0.x dev version.

anacolautti → made their first commit to this issue’s fork.

Hi @wim-leers. Sure, I hope this helps!

I believe this structure change

d9 settings:

settings
  toolbar
    rows 

to

d10 settings:

settings
  toolbar
    items 

is what broke my site. The error line was this one:

web/core/modules/ckeditor5/src/Plugin/CKEditor5PluginManager.php

if (empty(array_intersect($editor->getSettings()['toolbar']['items'], array_keys($definition->getToolbarItems())))) {
  unset($definitions[$plugin_id]);
}

and the error, that the first argument of array_intersect could not be null

In case this helps anyone, we were having a similar error:

TypeError: array_intersect(): Argument #1 ($array) must be of type array, null given in array_intersect() (line 203 of        
                                           web/core/modules/ckeditor5/src/Plugin/CKEditor5PluginManager.php

In our case, it happened because we updated our site to Drupal 10 but the configuration remained unchanged from our Drupal 9 previous version of the site. Then, the config element of the editor had a different structure that the CKEditor5PluginManager could not iterate.

We solved it by either editing and saving the text format again at /admin/config/content/formats, or deleting the faulty text format and creating it again (where the previous solution was not possible).

Thank you Vishakraman! looking forward to see this.
Let me know if you need any help

Thank you all very much for these fixes. Merged from gitlab and and closed!

Thank you very much @urvashi_vora, I really had very little time these past days to close this issue. I just merged the MR.
I'll create a release with this issue fix before the end of next week.

Thank you all!

Hi again!
I was able to reproduce this in D9.5.3. I was not able to reproduce in D10 since the module in use is not yet D10 ready.

Thank you @pmichelazzo for your code. I ended up using the once() function, based on the last fix on the related issue above (Multiple eye icon...). Adding the patch to this comment.

Please someone test this so that I can merge to the development branch and include in the next release.

This is probably related to Multiple eye icon 🐛 Multiple eye icon Fixed .
What browser are you using? and Drupal version? Let me know so I can try to reproduce it.
Thanks!

This release is now published. Thank you all.

Thank you everyone that helped fix this.

Thank you PhilY. I'll merge this and deploy today.

yay!

Ok, this is great, thank you all.
I reviewed the patch and had to do some modifications to be able to keep the functionality in these other issues that we also merged to dev:

- Issue #3228830 → by thalles: Selector previous input password error
- Issue #3324373 → by kkalashnikov, dineshkumarbollu, rishu_kumar, _pratik_: Drupal 10 compatibility

I tested this successfully in drupal/core:9.5.1 and drupal/core:10.0.x-dev.

I cannot reproduce the original bug, so if anyone else can confirm that this patch does the trick, let me know.
I can still add this patch to the dev branch, and merge it into the release 6.0.1 on Jan 30th 🌱 Road to release 6.0.2 Fixed .